Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: Disable debug draw modes that do not make sense depending on the current scene configuration or project settings #57408

Open
Zireael07 opened this issue Jan 29, 2022 · 2 comments

Comments

@Zireael07
Copy link
Contributor

Zireael07 commented Jan 29, 2022

Godot version

4.0 alpha 1

System information

Linux Manjaro, Vulkan, Intel Kaby Lake

Issue description

There's a laundry list of special display modes on Vulkan, which is awesome <3

But I haven't been able to figure out how some of these work (e.g. directional shadows, occlusion buffer don't seem to display anything for me), and I'm fairly sure some of these don't make sense without a related property/node being in the scene you're looking at:

  • all of the SDFGI modes
  • all VoxelGI modes
  • lightmapGI mode
  • directional shadow splits if no directional light in scene
  • fairly sure some more...

Please hide/make them unclickable when not relevant.

Also it would be nice to have a mode to show you which meshes are configured for GI at all, to avoid running into freezes/1fps if you happen to have GI with NO meshes set...

Steps to reproduce

Load up the editor, play around with the new options.

Minimal reproduction project

N/A

@Calinou
Copy link
Member

Calinou commented Jan 29, 2022

Related to #55900.

directional shadows

This debug draw mode is currently broken: #46129

occlusion buffer don't seem to display anything for me

This mode only works if occlusion culling is enabled in the project settings and you have an Occluder node present in your scene.

Also it would be nice to have a mode to show you which meshes are configured for GI at all, to avoid running into freezes/1fps if you happen to have GI with NO meshes set...

We should fix the original bug instead: #36121

@Calinou Calinou changed the title [4.0 a1] Advanced display modes list usability Vulkan: Disable debug draw modes that do not make sense depending on the current scene configuration or project settings Jan 29, 2022
@Calinou Calinou added this to the 4.0 milestone Jan 29, 2022
@Zireael07
Copy link
Contributor Author

Fixing the bug would be nice, but it would also help people NOT click bake only to realize they forgot to set up the meshes they wanted to use with GI :P

@akien-mga akien-mga removed this from the 4.0 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants