Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script search text match highlight persisting #77998

Closed
ghost opened this issue Jun 8, 2023 · 1 comment
Closed

Script search text match highlight persisting #77998

ghost opened this issue Jun 8, 2023 · 1 comment

Comments

@ghost
Copy link

ghost commented Jun 8, 2023

Godot version

v4.0.3.stable.official [5222a99]

System information

Windows 11, AMD Ryzen 5 3500U with Radeon Vega Mobile Gfx 2.10 GHz

Issue description

When searching for text in a script, if you switch to another script and then close the search bar, the original script (when you switch back to it) still has the highlighted search matches. The only way to remove them is to open the search bar and close it again which resets it. This can be fixed with a buffer history that is maintained when performing search matches until either the search text changes or the search bar is closed, at which point, the buffer can be traversed and the recorded scripts can have set_search_text () executed on them to reset their matched highlights, the buffer history cleared and the process continues, etc.

Steps to reproduce

Invoke the search bar in a script.
Type in text to search for.
Switch to another script.
Close the search bar.
Switch back to the original script.

Minimal reproduction project

N/A

@kitbdev
Copy link
Contributor

kitbdev commented Jul 2, 2024

@akien-mga akien-mga added this to the 4.3 milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants