-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Open
Labels
Description
Bug Description
Doesn't this just check for an error afterward? From what I see, the timeout doesn't actually stop the handler from running. It also doesn't pass the cancellation down the call stack, so inside the handler there's no way to check if the request has timed out.
fiber/middleware/timeout/timeout.go
Lines 25 to 28 in c309d46
tCtx, cancel := context.WithTimeout(ctx, timeout) | |
defer cancel() | |
err := runHandler(ctx, h, cfg) |
How to Reproduce
Steps to reproduce the behavior:
- Go to '....'
- Click on '....'
- Do '....'
- See '....'
Expected Behavior
Context(tCtx) with cancelation is passed down
Fiber Version
v3.0.0-beta.5
Code Snippet (optional)
Checklist:
- I agree to follow Fiber's Code of Conduct.
- I have checked for existing issues that describe my problem prior to opening this one.
- I understand that improperly formatted bug reports may be closed without explanation.