Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[subchain] stop forcing unnecessary app component re-renders #617

Open
brandonfancher opened this issue Nov 22, 2021 · 0 comments
Open

[subchain] stop forcing unnecessary app component re-renders #617

brandonfancher opened this issue Nov 22, 2021 · 0 comments
Labels
enhancement New feature or request frontend Frontend & UI Work

Comments

@brandonfancher
Copy link
Collaborator

I notice that each update forces subscribed components to re-render. For example, the NavProfile component (when depending on ship) re-renders multiple times per second. This is not gonna be great for performance. My guess is that it's because the subchain library's returning a new object with every update.

In the subchain library query hooks, we should do deep compares and only return a new object when there are actual changes.

@brandonfancher brandonfancher added enhancement New feature or request frontend Frontend & UI Work labels Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Frontend & UI Work
Projects
None yet
Development

No branches or pull requests

1 participant