Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote registry harbor is always healthy #21673

Open
gnetanel opened this issue Feb 26, 2025 · 4 comments · May be fixed by #21674
Open

Remote registry harbor is always healthy #21673

gnetanel opened this issue Feb 26, 2025 · 4 comments · May be fixed by #21674
Assignees
Labels
kind/bug more-info-needed The issue author need to provide more details and context to the issue

Comments

@gnetanel
Copy link

If you have a remote registry configured in Harbor, its stays healthy always because error handling prevents from setting it unhealthy in the code.

Also, the HealthCheck function is not implemented in the harbor adapter.

@gnetanel gnetanel linked a pull request Feb 26, 2025 that will close this issue
5 tasks
@stonezdj
Copy link
Contributor

stonezdj commented Mar 4, 2025

Can you please elaborate steps to reproduce the issue?

@reasonerjt reasonerjt added the more-info-needed The issue author need to provide more details and context to the issue label Mar 4, 2025
@bupd
Copy link
Contributor

bupd commented Mar 4, 2025

I can't reproduce this.

Image

Image

Looks like it turns unhealthy if the remote harbor registry fails. Btw, I think the the unhealthy depends on ping rather than healthcheck.

@gnetanel
Copy link
Author

gnetanel commented Mar 4, 2025

Login to harbor portal, under Administration->Registries, add a a new endpoint of type harbor
In the form, select Provider “Harbor”, and fill all the required details. (Endpoint URL, etc..), Click “TEST CONNECTION” button to verify it is accessible and click “OK” to create it

After that endpoint has been created successfully, you would see in the new endpoint added to
Administration->Registries and its status is “Healthy”.

Up till now all good.

Now simulate an issue on the remote endpoint and make it inaccessible, (e.g: change replica of core to 0, or any other approach you want to make endpoint not reachable), as a result, the excepted behavior is that the “Status” column will be modify to “Unhealthy”, but it remain “Healthy” regardless if endpoint is accessible or not. (you can refresh the page to see it does make any changes)

Attaching a screenshot showing two endpoint one with Healthy, and second with Unhealthy (before my code change, both were Healthy regardless if there were accessible or not)

Image

@bupd
Copy link
Contributor

bupd commented Mar 4, 2025

Even without the changes too. it stays the same. you can try reproducing this in the https://demo.goharbor.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug more-info-needed The issue author need to provide more details and context to the issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants