{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":23096959,"defaultBranch":"master","name":"go","ownerLogin":"golang","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-08-19T04:33:40.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/4314092?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1718987570.0","currentOid":""},"activityList":{"items":[{"before":"b0927fdd494a79458ff151ce8db59963f67b80be","after":"ea537cca314d9da5365eeefcc375410c76e93b36","ref":"refs/heads/master","pushedAt":"2024-06-27T17:42:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/go/internal/help: add documentation for language version downgrading\n\nThis change adds documentation for language version downgrading using\nbuild constraints.\n\nFixes #68161\nFor #61894\n\nChange-Id: I283a51afd7020c9fd1f5469a6a93fd814ba32f7e\nReviewed-on: https://go-review.googlesource.com/c/go/+/595475\nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd/go/internal/help: add documentation for language version downgrading"}},{"before":"5a18e79687dea15680ff5f799b549fa0efd0cad9","after":"b0927fdd494a79458ff151ce8db59963f67b80be","ref":"refs/heads/master","pushedAt":"2024-06-27T17:18:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"slices: update docs for All, Backward, Values\n\nFor #61899\n\nChange-Id: I3586b9b59e87159d21e1a270dabb3af213592739\nReviewed-on: https://go-review.googlesource.com/c/go/+/595515\nAuto-Submit: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Alan Donovan \nReviewed-by: Ian Lance Taylor ","shortMessageHtmlLink":"slices: update docs for All, Backward, Values"}},{"before":"ceaf26ecce663e75c4f4b476dc3c64fa58a2f0dd","after":"c2d4f852ce69fc2674d45ccd3090757dd01cc2d4","ref":"refs/heads/release-branch.go1.22","pushedAt":"2024-06-26T22:23:47.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.22] cmd/link: handle dynamic import variables on Darwin in plugin mode\n\nCL 501855 added support for cgo_dynamic_import variables on Darwin.\nBut it didn't support the plugin build mode on amd64, where the\nassembler turns a direct load (R_PCREL) to a load via GOT\n(R_GOTPCREL). This CL adds the support. We just need to handle\nexternal linking mode, as this can only occur in plugin or shared\nbuild mode, which requires external linking.\n\nFixes #68122.\nUpdates #67976.\nUpdates #50891.\n\nChange-Id: I0f56265d50bfcb36047fa5538ad7a5ec77e7ef96\nReviewed-on: https://go-review.googlesource.com/c/go/+/592499\nReviewed-by: David Chase \nLUCI-TryBot-Result: Go LUCI \n(cherry picked from commit 44f18706661db8b865719d15a5cfa0515d1a4fca)\nReviewed-on: https://go-review.googlesource.com/c/go/+/595175\nReviewed-by: Joedian Reid \nReviewed-by: Than McIntosh ","shortMessageHtmlLink":"[release-branch.go1.22] cmd/link: handle dynamic import variables on …"}},{"before":"ac14d4d9cea31109b475bdba3cc8afd823a07c21","after":"c9be6ae748b7679b644a38182d456cb5a6ac06ee","ref":"refs/heads/release-branch.go1.21","pushedAt":"2024-06-26T22:23:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.21] net/http: send body or close connection on expect-100-continue requests\n\nWhen sending a request with an \"Expect: 100-continue\" header,\nwe must send the request body before sending any further requests\non the connection.\n\nWhen receiving a non-1xx response to an \"Expect: 100-continue\" request,\nsend the request body if the connection isn't being closed after\nprocessing the response. In other words, if either the request\nor response contains a \"Connection: close\" header, then skip sending\nthe request body (because the connection will not be used for\nfurther requests), but otherwise send it.\n\nCorrect a comment on the server-side Expect: 100-continue handling\nthat implied sending the request body is optional. It isn't.\n\nFor #67555\nFixes #68199\n\nChange-Id: Ia2f12091bee697771087f32ac347509ec5922d54\nReviewed-on: https://go-review.googlesource.com/c/go/+/591255\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Jonathan Amsterdam \n(cherry picked from commit cf501e05e138e6911f759a5db786e90b295499b9)\nReviewed-on: https://go-review.googlesource.com/c/go/+/595096\nReviewed-by: Joedian Reid \nReviewed-by: Dmitri Shuralyov ","shortMessageHtmlLink":"[release-branch.go1.21] net/http: send body or close connection on ex…"}},{"before":"5f319b75075a62ab176ab8c25f0e45f2ae4f0704","after":"5a18e79687dea15680ff5f799b549fa0efd0cad9","ref":"refs/heads/master","pushedAt":"2024-06-26T16:18:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/link: don't skip code sign even if dsymutil didn't generate a file\n\nEven if dsymutil didn't generate a file (which should not happen\nwith the Apple toolchain with the correct setup), we should not\nskip next steps, e.g. code sign. A return statement makes it exit\ntoo early.\n\nUpdates #68088.\n\nChange-Id: Ic1271ed1b7fe5bdee5a25cc5d669a105173b389e\nReviewed-on: https://go-review.googlesource.com/c/go/+/593660\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Than McIntosh ","shortMessageHtmlLink":"cmd/link: don't skip code sign even if dsymutil didn't generate a file"}},{"before":"a2e90be996fb0e75966b1e1097dd20aa07eebc37","after":"5f319b75075a62ab176ab8c25f0e45f2ae4f0704","ref":"refs/heads/master","pushedAt":"2024-06-26T16:17:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/link: don't let dsymutil delete our temp directory\n\nTo work around #59026, where dsymutil may not clean up its temp\ndirectory at exit, we set DSYMUTIL_REPRODUCER_PATH to our temp\ndirectory so it uses that, and we can delete it at the end.\n\nIn Xcode 16 beta, dsymutil deletes the DSYMUTIL_REPRODUCER_PATH\ndirectory even if it is not empty. We still need our tmpdir at the\npoint, so give a subdirectory to dsymutil instead.\n\nFor #68088.\n\nChange-Id: I18759cc39512819bbd0511793ce917eae72245d6\nReviewed-on: https://go-review.googlesource.com/c/go/+/593659\nReviewed-by: Than McIntosh \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd/link: don't let dsymutil delete our temp directory"}},{"before":"90bcc552c0347948166817a602f612f219bc980c","after":"a2e90be996fb0e75966b1e1097dd20aa07eebc37","ref":"refs/heads/master","pushedAt":"2024-06-26T16:11:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"os: rewrite TestChtimesWithZeroTimes\n\nFirst, this enables checks on DragonFly BSD, which partially works since\nCL 589496 (except two things: atime is not supported on hammer2 fs, and\nwhen both times are omitted, it doesn't work due to a kernel bug).\n\nSecond, there are a few problems with TestChtimesWithZeroTimes:\n\n - test cases are interdependent (former cases influence the latter ones),\n making the test using too many different times and also hard to read;\n\n - time is changed forward not backward which could be racy;\n\n - if the test has failed, it hard to see which exact case is failing.\n\nPlus, there are issues with the error exclusion code in\nTestChtimesWithZeroTimes:\n\n - the atime comparison is done twice for the default (\"unix\") case;\n\n - the atime exclusion caused by noatime mount flag applies to all\n unixes rather than netbsd only as it should;\n\n - the atime exclusion tries to read wrong files (/bin/mounts and\n /etc/mtab instead of /proc/mounts);\n\n - the exclusion for netbsd is only applied for 64-bit arches, which\n seems wrong (and I've reproduced noatime issue on NetBSD 9.4/i386).\n\nLet's rewrite it, fixing all these issues, and rename to\nTestChtimesOmit.\n\nNB: TestChtimes can now be removed.\n\nChange-Id: If9020256ca920b4db836a1f0b2e055b5fce4a552\nReviewed-on: https://go-review.googlesource.com/c/go/+/591535\nAuto-Submit: Ian Lance Taylor \nReviewed-by: Ian Lance Taylor \nReviewed-by: Joedian Reid \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"os: rewrite TestChtimesWithZeroTimes"}},{"before":"dfe4dbf8c055f79758ce7ae3d3ab2d0e4a0ea9ee","after":"ceaf26ecce663e75c4f4b476dc3c64fa58a2f0dd","ref":"refs/heads/release-branch.go1.22","pushedAt":"2024-06-26T14:01:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.22] cmd/compile: mark pointer to noalg type as noalg\n\nWhen the compiler writes PtrToThis field of noalg type, it generates\nits pointer type. Mark them as noalg to prevent put them in typelinks.\n\nFixes #65983\n\nChange-Id: Icbc3b18bc866f9138c7648e42dd500a80326f72b\nReviewed-on: https://go-review.googlesource.com/c/go/+/567335\nReviewed-by: Matthew Dempsky \nAuto-Submit: Keith Randall \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Keith Randall \n(cherry picked from commit b8c76effd9a3a30d66e44ed7acea789e4e95b926)\nReviewed-on: https://go-review.googlesource.com/c/go/+/593876\nReviewed-by: David Chase ","shortMessageHtmlLink":"[release-branch.go1.22] cmd/compile: mark pointer to noalg type as noalg"}},{"before":"b1fd047508aad9f5038dc04d78146cc582328bf5","after":"90bcc552c0347948166817a602f612f219bc980c","ref":"refs/heads/master","pushedAt":"2024-06-25T17:08:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"crypto/tls: apply QUIC session event flag to QUICResumeSession events\n\nGo 1.23 adds two new events to QUICConns: QUICStoreSessionEvent and\nQUICResumeSessionEvent. We added a QUICConfig.EnableStoreSessionEvent\nflag to control whether the store-session event is provided or not,\nbecause receiving this event requires additional action from the caller:\nthe session must be explicitly stored with QUICConn.StoreSession.\n\nWe did not add a control for whether the resume-session event is\nprovided, because this event requires no action and the caller is\nexpected to ignore unknown events.\n\nHowever, we never documented the expectation that callers ignore\nunknown events, and quic-go produces an error when receiving an\nunexpected event. So change the EnableStoreSessionEvent flag to\napply to both new events.\n\nFixes #68124\nFor #63691\n\nChange-Id: I84af487e52b3815f7b648e09884608f8915cd645\nReviewed-on: https://go-review.googlesource.com/c/go/+/594475\nReviewed-by: Marten Seemann \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Roland Shoemaker ","shortMessageHtmlLink":"crypto/tls: apply QUIC session event flag to QUICResumeSession events"}},{"before":"b3b4556c245c8f21872910ee866133428bbb5a60","after":"b1fd047508aad9f5038dc04d78146cc582328bf5","ref":"refs/heads/master","pushedAt":"2024-06-25T14:29:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/internal/obj/arm64: fix return with register\n\nARM64 allows for a register to be specified with a return\ninstruction. While the assembler parsing and encoding currently\nsupports this, the preprocess function uses LR unconditionally.\nCorrect this such that if a register is specified, the register\nis used.\n\nChange-Id: I708f6c7e910d141559b60d2d5ee76ae2e1dc3a0e\nReviewed-on: https://go-review.googlesource.com/c/go/+/592796\nReviewed-by: Cherry Mui \nReviewed-by: David Chase \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd/internal/obj/arm64: fix return with register"}},{"before":"68315bc8ce8c7fd1a9e47e73b2d18ef21f8c6d9a","after":"b3b4556c245c8f21872910ee866133428bbb5a60","ref":"refs/heads/master","pushedAt":"2024-06-25T00:12:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/compile: update README to reflect dead code elimination changes\n\nThe description of middle-end dead code elimination is inconsistent with the current implementation.\n\nThe early dead code elimination pass of IR nodes is no longer located in cmd/compile/internal/deadcode and is no longer called by gc/main.go:Main. It has been moved to the unified IR writer phase. This update modifies the README to reflect this architectural change.\n\nChange-Id: I78bd486edefd6b02948fee7de9ce6c83b147bc1d\nGitHub-Last-Rev: 76493ce8b08cd585d761d65d29b984360f7ee628\nGitHub-Pull-Request: golang/go#68134\nReviewed-on: https://go-review.googlesource.com/c/go/+/593638\nReviewed-by: Robert Griesemer \nReviewed-by: Keith Randall \nReviewed-by: Keith Randall \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Keith Randall ","shortMessageHtmlLink":"cmd/compile: update README to reflect dead code elimination changes"}},{"before":"f214a760754ac0584999fb8098ce6172181ed791","after":"68315bc8ce8c7fd1a9e47e73b2d18ef21f8c6d9a","ref":"refs/heads/master","pushedAt":"2024-06-24T21:08:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd: run go mod tidy after CL 593684\n\nReported by TestAllDependencies/cmd(thorough) in cmd/internal/moddeps.\n\nChange-Id: I897baf00efbfebd07abe387f54c7ce4fc14444e6\nCq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest\nReviewed-on: https://go-review.googlesource.com/c/go/+/594536\nAuto-Submit: Dmitri Shuralyov \nReviewed-by: Hyang-Ah Hana Kim \nReviewed-by: Dmitri Shuralyov \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd: run go mod tidy after CL 593684"}},{"before":"3560cf0afb3c29300a6c88ccd98256949ca7a6f6","after":"dfe4dbf8c055f79758ce7ae3d3ab2d0e4a0ea9ee","ref":"refs/heads/release-branch.go1.22","pushedAt":"2024-06-24T20:40:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.22] os/exec: on Windows look for extensions in Run if not already done\n\nCL 512155 fixed #36768, but introduced #62596.\nCL 527820 fixed #62596, but meant that the code failed to look up\nfile extensions on Windows for a relative path.\nThis CL fixes that problem by recording whether it has already\nlooked up file extensions.\nThis does mean that if Path is set manually then we do not update\nit with file extensions, as doing that would be racy.\n\nFor #66586\nFixes #66598\n\nChange-Id: I9a0305d1e466c5e07bfbe442566ea12f5255a96e\nGitHub-Last-Rev: dc3169f2350f61acac5ef7842b7514013abacbe1\nGitHub-Pull-Request: golang/go#67035\nReviewed-on: https://go-review.googlesource.com/c/go/+/581695\nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Ian Lance Taylor \nReviewed-by: Michael Knyszek \nReviewed-by: Ian Lance Taylor \n(cherry picked from commit 5532427c4b1c5e962ad5484258be0071bd270e53)\nReviewed-on: https://go-review.googlesource.com/c/go/+/594495\nReviewed-by: Dmitri Shuralyov \nReviewed-by: Dmitri Shuralyov \nCommit-Queue: Ian Lance Taylor ","shortMessageHtmlLink":"[release-branch.go1.22] os/exec: on Windows look for extensions in Ru…"}},{"before":"29b1a6765fb5f124171d94f157b6d6c3b2687468","after":"f214a760754ac0584999fb8098ce6172181ed791","ref":"refs/heads/master","pushedAt":"2024-06-24T18:56:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/vendor: vendor x/telemetry@38a4430\n\nFor #68109\n\nChange-Id: I73a3d23dd6c15ff4954ebe7a52c6c308fea947ae\nReviewed-on: https://go-review.googlesource.com/c/go/+/593684\nReviewed-by: Michael Matloob \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Hyang-Ah Hana Kim ","shortMessageHtmlLink":"cmd/vendor: vendor x/telemetry@38a4430"}},{"before":"5159a7193ac77b26c7fa7b18309e17709358a411","after":"3560cf0afb3c29300a6c88ccd98256949ca7a6f6","ref":"refs/heads/release-branch.go1.22","pushedAt":"2024-06-24T17:52:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.22] runtime: always update stack bounds on cgocallback\n\ncallbackUpdateSystemStack contains a fast path to exit early without\nupdate if SP is already within the g0.stack bounds.\n\nThis is not safe, as a subsequent call may have new stack bounds that\nonly partially overlap the old stack bounds. In this case it is possible\nto see an SP that is in the old stack bounds, but very close to the\nbottom of the bounds due to the partial overlap. In that case we're very\nlikely to \"run out\" of space on the system stack.\n\nWe only need to do this on extra Ms, as normal Ms have precise bounds\ndefined when we allocated the stack.\n\nTSAN annotations are added to x_cgo_getstackbounds because bounds is a\npointer into the Go stack. The stack can be reused when an old thread\nexits and a new thread starts, but TSAN can't see the synchronization\nthere. This isn't a new case, but we are now calling more often.\n\nFor #62440.\nFixes #67298.\n\nCq-Include-Trybots: luci.golang.try:go1.22-linux-amd64-longtest\nChange-Id: I5389050494987b7668d0b317fb92f85e61d798ac\nReviewed-on: https://go-review.googlesource.com/c/go/+/584597\nReviewed-by: Cherry Mui \nLUCI-TryBot-Result: Go LUCI \n(cherry picked from commit 1ffc296717ba27d5ca5dd9a81439a49367363c89)\nReviewed-on: https://go-review.googlesource.com/c/go/+/585935\nRun-TryBot: Joedian Reid \nTryBot-Result: Gopher Robot ","shortMessageHtmlLink":"[release-branch.go1.22] runtime: always update stack bounds on cgocal…"}},{"before":"29d378aa877210a4c6eed3110a0b1744ae71431c","after":"ac14d4d9cea31109b475bdba3cc8afd823a07c21","ref":"refs/heads/release-branch.go1.21","pushedAt":"2024-06-24T17:52:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.21] runtime: always update stack bounds on cgocallback\n\ncallbackUpdateSystemStack contains a fast path to exit early without\nupdate if SP is already within the g0.stack bounds.\n\nThis is not safe, as a subsequent call may have new stack bounds that\nonly partially overlap the old stack bounds. In this case it is possible\nto see an SP that is in the old stack bounds, but very close to the\nbottom of the bounds due to the partial overlap. In that case we're very\nlikely to \"run out\" of space on the system stack.\n\nWe only need to do this on extra Ms, as normal Ms have precise bounds\ndefined when we allocated the stack.\n\nTSAN annotations are added to x_cgo_getstackbounds because bounds is a\npointer into the Go stack. The stack can be reused when an old thread\nexits and a new thread starts, but TSAN can't see the synchronization\nthere. This isn't a new case, but we are now calling more often.\n\nFor #62440.\nFixes #67297.\n\nCq-Include-Trybots: luci.golang.try:go1.21-linux-amd64-longtest\nChange-Id: I5389050494987b7668d0b317fb92f85e61d798ac\nReviewed-on: https://go-review.googlesource.com/c/go/+/584597\nReviewed-by: Cherry Mui \nLUCI-TryBot-Result: Go LUCI \n(cherry picked from commit 1ffc296717ba27d5ca5dd9a81439a49367363c89)\nReviewed-on: https://go-review.googlesource.com/c/go/+/585337","shortMessageHtmlLink":"[release-branch.go1.21] runtime: always update stack bounds on cgocal…"}},{"before":"cf54a3d11469e3e9bd531ee2cdeaf613467923f1","after":"29b1a6765fb5f124171d94f157b6d6c3b2687468","ref":"refs/heads/master","pushedAt":"2024-06-24T17:22:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"net/http: document that Request.Clone does not deep copy Body\n\nFixes #36095\n\nChange-Id: I94ae014b0ee45b4aeb38cb247e42cfc13f663ded\nReviewed-on: https://go-review.googlesource.com/c/go/+/593175\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Jonathan Amsterdam ","shortMessageHtmlLink":"net/http: document that Request.Clone does not deep copy Body"}},{"before":"11b861e45936eb7911e30304163a14553f53a5d1","after":"5159a7193ac77b26c7fa7b18309e17709358a411","ref":"refs/heads/release-branch.go1.22","pushedAt":"2024-06-24T17:15:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.22] cmd/compile: put constants before variables in initialization order\n\nFixes #67820.\n\nChange-Id: I03f4d4577b88ad0a92b260b2efd0cb9fe5082b2f\nReviewed-on: https://go-review.googlesource.com/c/go/+/575075\nReviewed-by: Robert Griesemer \nReviewed-by: Keith Randall \nLUCI-TryBot-Result: Go LUCI \nReviewed-on: https://go-review.googlesource.com/c/go/+/590395\nReviewed-by: Michael Knyszek \nReviewed-by: Keith Randall ","shortMessageHtmlLink":"[release-branch.go1.22] cmd/compile: put constants before variables i…"}},{"before":"81fc6162675ea2543aa30ae35e56769c3d8a39ca","after":"11b861e45936eb7911e30304163a14553f53a5d1","ref":"refs/heads/release-branch.go1.22","pushedAt":"2024-06-24T17:14:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.22] go/types, types2: report error for floating-point iteration variable\n\nWhile at it, slightly improve documentation and code.\nAlso, add additional test cases for #66561.\n\nUpdates #66561.\nFixes #67798.\n\nChange-Id: I682b0e9227e065d6bbd199871c2e1ecff13edc66\nReviewed-on: https://go-review.googlesource.com/c/go/+/580937\nReviewed-by: Robert Griesemer \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley \nAuto-Submit: Robert Griesemer \nReviewed-on: https://go-review.googlesource.com/c/go/+/590056","shortMessageHtmlLink":"[release-branch.go1.22] go/types, types2: report error for floating-p…"}},{"before":"14f0251867fbc400674333723e4d6e0dab122761","after":"81fc6162675ea2543aa30ae35e56769c3d8a39ca","ref":"refs/heads/release-branch.go1.22","pushedAt":"2024-06-24T17:12:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.22] crypto/tls: don't call tlsrsakex.IncNonDefault with FIPS\n\nWe haven't called tlsrsakex.Value() yet at this point if we're using\nFIPS, like if CipherSuites != nil. This adds needFIPS as a gate next to\nCipherSuites != nil. FIPS specifies suites that would be skipped if\ntlsarsakex were set.\n\nFor #65991.\nFixes #65994.\n\nChange-Id: I8070d8f43f27c04067490af8cc7ec5e787f2b9bd\nReviewed-on: https://go-review.googlesource.com/c/go/+/582315\nReviewed-by: Filippo Valsorda \nReviewed-by: Cherry Mui \nTryBot-Bypass: Filippo Valsorda \nAuto-Submit: Filippo Valsorda \nReviewed-by: Dmitri Shuralyov \n(cherry picked from commit 78e50d0fa0bc78d197bd1b41e1bdef8c20a03396)\nReviewed-on: https://go-review.googlesource.com/c/go/+/593395\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Roland Shoemaker ","shortMessageHtmlLink":"[release-branch.go1.22] crypto/tls: don't call tlsrsakex.IncNonDefaul…"}},{"before":"ab60a7bc18c990513532b4d33c1e2673fb1ea703","after":"14f0251867fbc400674333723e4d6e0dab122761","ref":"refs/heads/release-branch.go1.22","pushedAt":"2024-06-24T17:08:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.22] cmd/cgo/internal/swig: force use of lld for LTO tests on the builders\n\nFor whatever reason, on the builders, when using /usr/bin/ld (the\ndefault linker) with -flto we end up with problems. Specifically, the\nlinker seems to require LLVMgold.so and can't find it. I'm not really\nsure why, but what definitely seems to work is forcing use of lld, which\nships with our clang installation on the builders.\n\nJust enforce this on the builders for now; I've actually had very few\nproblems running this locally (and I think I'm also mixing and matching\nlinkers and toolchains too...), so it may be related to the version of\nclang we're testing with.\n\nFor #67698.\nFor #67715.\n\nChange-Id: I3bfbcd609e7d0fd70e52ac7e2a0817db95664f20\nCq-Include-Trybots: luci.golang.try:go1.22-linux-amd64-clang15,go1.22-linux-386-clang15\nReviewed-on: https://go-review.googlesource.com/c/go/+/589296\nAuto-Submit: Dmitri Shuralyov \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Dmitri Shuralyov \nReviewed-by: Dmitri Shuralyov \nReviewed-on: https://go-review.googlesource.com/c/go/+/591375","shortMessageHtmlLink":"[release-branch.go1.22] cmd/cgo/internal/swig: force use of lld for L…"}},{"before":"537ec6f21ec4b69142b9c5c9f8bcb2c66cf68274","after":"29d378aa877210a4c6eed3110a0b1744ae71431c","ref":"refs/heads/release-branch.go1.21","pushedAt":"2024-06-24T17:08:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.21] cmd/cgo/internal/testsanitizers: make the libfuzzer tests all short\n\nCL 589295 only made one of the two tests short, because the other one\nseemed to be passing consistently in short mode. On the builders, it\nseems to still fail maybe 30% of the time by taking too long. Disable\nthese tests in short mode.\n\nThis CL was merged with CL 589295 before cherry-picking.\n\nFor #67698.\nFixes #67714.\n\nChange-Id: I9fd047f834f7493b608dd1fee5b9b6dfabbea03d\nCq-Include-Trybots: luci.golang.try:go1.21-linux-amd64-clang15,go1.21-linux-386-clang15\nReviewed-on: https://go-review.googlesource.com/c/go/+/589495\nAuto-Submit: Michael Knyszek \nReviewed-by: Dmitri Shuralyov \nLUCI-TryBot-Result: Go LUCI \nCommit-Queue: Michael Knyszek \nReviewed-on: https://go-review.googlesource.com/c/go/+/591378","shortMessageHtmlLink":"[release-branch.go1.21] cmd/cgo/internal/testsanitizers: make the lib…"}},{"before":"4c97e883b5f062344180adb22266a8bf48c19a23","after":"ab60a7bc18c990513532b4d33c1e2673fb1ea703","ref":"refs/heads/release-branch.go1.22","pushedAt":"2024-06-24T17:06:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.22] cmd/cgo/internal/testsanitizers: make the libfuzzer tests all short\n\nCL 589295 only made one of the two tests short, because the other one\nseemed to be passing consistently in short mode. On the builders, it\nseems to still fail maybe 30% of the time by taking too long. Disable\nthese tests in short mode.\n\nThis CL was merged with CL 589295 before cherry-picking.\n\nFor #67698.\nFixes #67715.\n\nChange-Id: I9fd047f834f7493b608dd1fee5b9b6dfabbea03d\nCq-Include-Trybots: luci.golang.try:go1.22-linux-amd64-clang15,go1.22-linux-386-clang15\nReviewed-on: https://go-review.googlesource.com/c/go/+/589495\nAuto-Submit: Michael Knyszek \nReviewed-by: Dmitri Shuralyov \nLUCI-TryBot-Result: Go LUCI \nCommit-Queue: Michael Knyszek \nReviewed-on: https://go-review.googlesource.com/c/go/+/591376","shortMessageHtmlLink":"[release-branch.go1.22] cmd/cgo/internal/testsanitizers: make the lib…"}},{"before":"dfb006701893e0ac9fc12ab2bbd65e1d61c517c8","after":"537ec6f21ec4b69142b9c5c9f8bcb2c66cf68274","ref":"refs/heads/release-branch.go1.21","pushedAt":"2024-06-24T17:06:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.21] cmd/cgo/internal/swig: force use of lld for LTO tests on the builders\n\nFor whatever reason, on the builders, when using /usr/bin/ld (the\ndefault linker) with -flto we end up with problems. Specifically, the\nlinker seems to require LLVMgold.so and can't find it. I'm not really\nsure why, but what definitely seems to work is forcing use of lld, which\nships with our clang installation on the builders.\n\nJust enforce this on the builders for now; I've actually had very few\nproblems running this locally (and I think I'm also mixing and matching\nlinkers and toolchains too...), so it may be related to the version of\nclang we're testing with.\n\nFor #67698.\nFor #67714.\n\nChange-Id: I3bfbcd609e7d0fd70e52ac7e2a0817db95664f20\nCq-Include-Trybots: luci.golang.try:go1.21-linux-amd64-clang15,go1.21-linux-386-clang15\nReviewed-on: https://go-review.googlesource.com/c/go/+/589296\nAuto-Submit: Dmitri Shuralyov \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Dmitri Shuralyov \nReviewed-by: Dmitri Shuralyov \nReviewed-on: https://go-review.googlesource.com/c/go/+/591377","shortMessageHtmlLink":"[release-branch.go1.21] cmd/cgo/internal/swig: force use of lld for L…"}},{"before":"179ccb7042b805b78b76151981f7a7f53f3d2968","after":"4c97e883b5f062344180adb22266a8bf48c19a23","ref":"refs/heads/release-branch.go1.22","pushedAt":"2024-06-24T17:00:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.22] cmd/link: put runtime.end in the last section of data segment\n\nCurrently the runtime.end symbol is put into the noptrbss section,\nwhich is usually the last section, except that when fuzzing is\nenabled, the last section is actually .go.fuzzcntrs. The\nruntime.end symbol has the value pointing to the end of the data\nsegment, so if it is not in the last section, the value will not\nactually be in the range of the section. This causes an assertion\nfailure in the new Apple linker. This CL fixes this by putting it\nin the last section.\n\nUpdates #65169.\nFixes #67945.\n\nChange-Id: I5c991c46a0483a96e5f6e0255a3b444953676026\nReviewed-on: https://go-review.googlesource.com/c/go/+/592095\nReviewed-by: Than McIntosh \nLUCI-TryBot-Result: Go LUCI \n(cherry picked from commit b589478af7f4b09cc9c4d5f76fbbf5cad2b2b7bb)\nReviewed-on: https://go-review.googlesource.com/c/go/+/592478","shortMessageHtmlLink":"[release-branch.go1.22] cmd/link: put runtime.end in the last section…"}},{"before":"e65014d0593debe036ebbb3691843caf8cdfe61d","after":"dfb006701893e0ac9fc12ab2bbd65e1d61c517c8","ref":"refs/heads/release-branch.go1.21","pushedAt":"2024-06-24T17:00:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.21] cmd/link: put runtime.end in the last section of data segment\n\nCurrently the runtime.end symbol is put into the noptrbss section,\nwhich is usually the last section, except that when fuzzing is\nenabled, the last section is actually .go.fuzzcntrs. The\nruntime.end symbol has the value pointing to the end of the data\nsegment, so if it is not in the last section, the value will not\nactually be in the range of the section. This causes an assertion\nfailure in the new Apple linker. This CL fixes this by putting it\nin the last section.\n\nUpdates #65169.\nFixes #67944.\n\nChange-Id: I5c991c46a0483a96e5f6e0255a3b444953676026\nReviewed-on: https://go-review.googlesource.com/c/go/+/592095\nReviewed-by: Than McIntosh \nLUCI-TryBot-Result: Go LUCI \n(cherry picked from commit b589478af7f4b09cc9c4d5f76fbbf5cad2b2b7bb)\nReviewed-on: https://go-review.googlesource.com/c/go/+/592477","shortMessageHtmlLink":"[release-branch.go1.21] cmd/link: put runtime.end in the last section…"}},{"before":"fe9b3c339978f37aad53875d9e6d2df35a1996ad","after":"179ccb7042b805b78b76151981f7a7f53f3d2968","ref":"refs/heads/release-branch.go1.22","pushedAt":"2024-06-24T16:58:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.22] cmd/go: fix go list -u -m all with too new retractions dependency\n\nPreviously, go would not report retractions of dependencies that have a\nnewer version of Go. With this change, we will still display retractions despite a version difference when go list -u -m is used.\n\nFor: #66403\nFixes: #68052\n\nChange-Id: I6406680235e294269836ae4cbe3d5680ca10eea0\nReviewed-on: https://go-review.googlesource.com/c/go/+/588775\nAuto-Submit: Sam Thanawalla \nReviewed-by: Michael Matloob \nLUCI-TryBot-Result: Go LUCI \n(cherry picked from commit e44fa1c1a9139ad457d8fa84a68afa3f40e7732a)\nReviewed-on: https://go-review.googlesource.com/c/go/+/593355","shortMessageHtmlLink":"[release-branch.go1.22] cmd/go: fix go list -u -m all with too new re…"}},{"before":"74ac37e9da31d6ab37575e7f2d7287fbb6b168d9","after":"e65014d0593debe036ebbb3691843caf8cdfe61d","ref":"refs/heads/release-branch.go1.21","pushedAt":"2024-06-24T16:58:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[release-branch.go1.21] cmd/go: fix go list -u -m all with too new retractions dependency\n\nPreviously, go would not report retractions of dependencies that have a\nnewer version of Go. With this change, we will still display retractions despite a version difference when go list -u -m is used.\n\nFor: #66403\nFixes: #68051\n\nChange-Id: I6406680235e294269836ae4cbe3d5680ca10eea0\nReviewed-on: https://go-review.googlesource.com/c/go/+/588775\nAuto-Submit: Sam Thanawalla \nReviewed-by: Michael Matloob \nLUCI-TryBot-Result: Go LUCI \n(cherry picked from commit e44fa1c1a9139ad457d8fa84a68afa3f40e7732a)\nReviewed-on: https://go-review.googlesource.com/c/go/+/593375","shortMessageHtmlLink":"[release-branch.go1.21] cmd/go: fix go list -u -m all with too new re…"}},{"before":"b98803e8e5e4e3077207d5c473f1938dfd9dcff2","after":"cf54a3d11469e3e9bd531ee2cdeaf613467923f1","ref":"refs/heads/master","pushedAt":"2024-06-24T16:40:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"crypto/tls: replay test recordings without network\n\nThere is no reason to go across a pipe when replaying a conn recording.\nThis avoids the complexity of using localPipe and goroutines, and makes\nhandshake benchmarks more accurate, as we don't measure network\noverhead.\n\nAlso note how it removes the need for -fast: operating locally we know\nwhen the flow is over and can error out immediately, without waiting for\na read from the feeder on the other side of the pipe to timeout.\n\nAvoids some noise in #67979, but doesn't fix the two root causes:\nlocalPipe flakes and testing.B races.\n\nUpdates #67979\n\nChange-Id: I153d3fa5a24847f3947823e8c3a7bc639f89bc1d\nReviewed-on: https://go-review.googlesource.com/c/go/+/594255\nAuto-Submit: Filippo Valsorda \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Roland Shoemaker \nReviewed-by: Joedian Reid ","shortMessageHtmlLink":"crypto/tls: replay test recordings without network"}},{"before":"0def9d5c02166b50a011b4cc8d4c1d891a04f89d","after":"b98803e8e5e4e3077207d5c473f1938dfd9dcff2","ref":"refs/heads/master","pushedAt":"2024-06-24T16:40:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"os: TestChtimes: separate hasNoatime\n\nMove the noatime check to a separate function (to be used by CL 91535),\nadding some documentation along the way.\n\nUnify the atime error message.\n\nChange-Id: I5f75a4399f6e1b16ae20438003de5460f3eeb5aa\nReviewed-on: https://go-review.googlesource.com/c/go/+/594075\nReviewed-by: Ian Lance Taylor \nReviewed-by: Joedian Reid \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Ian Lance Taylor ","shortMessageHtmlLink":"os: TestChtimes: separate hasNoatime"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEcRy7zAA","startCursor":null,"endCursor":null}},"title":"Activity · golang/go"}