x/tools/gopls: address formatting issues with [email protected]

[findleyr]

In #45648, we discovered that gopls has formatting bugs when built with github.com/sergi/[email protected]. Unfortunately, there are probably many users that get this version due to installing with go get -u.

Until sergi/go-diff#115 is fixed, or we find some other solution, we should at least warn users when built with [email protected].

CC @stamblerre @heschi

[gopherbot]

Change https://golang.org/cl/315852 mentions this issue: internal/lsp: warn users who have built gopls with go-diff v1.2.0

[stamblerre]

I don't think there's anything to do here. All that remains is waiting for sergi/go-diff#120 to be merged.

[FrankFang]

What's the correct way to install x/tools/gopls?

[findleyr]

See https://github.com/golang/tools/tree/master/gopls#installation

GO111MODULE=on go get golang.org/x/tools/gopls@latest

[OscarVanL]

The VS Code Go Extension has started complaining about a bad gopls installation, linking to this issue.

I tried running the command suggested by VS Code to fix it (same as above) but it says:

go get: installing executables with 'go get' in module mode is deprecated.
        Use 'go install pkg@version' instead.
        For more information, see https://golang.org/doc/go-get-install-deprecation
        or run 'go help get' or 'go help install'.

If I run go install golang.org/x/tools/gopls@latestI get no console output whatsoever and the error message does not go away.

Any idea what to do? Lots of stuff seems to be misbehaving. When I have the "go.useLanguageServer": true,option set VS Code will give incorrect errors on every third-party import, such as:

"gopkg.in/yaml.v3" imported but not usedcompilerUnusedImport
could not import gopkg.in/yaml.v3 (cannot find package "gopkg.in/yaml.v3" in any of 
	/usr/local/Cellar/go/1.17.1/libexec/src/gopkg.in/yaml.v3 (from $GOROOT)
	/Users/oscarvanleusen/go/src/gopkg.in/yaml.v3 (from $GOPATH))

However, this library must be installed as the code compiles fine (and yaml functions work). If I disable the language server the warning goes away.

Here's my settings.json file.

{
    "workbench.colorTheme": "Default Dark+",
    "files.autoSave": "afterDelay",
    "go.useLanguageServer": true,
    "go.languageServerExperimentalFeatures": {
            "diagnostics": true // for diagnostics as you type
    },
    "[go]": {
        "editor.insertSpaces": false,
        "editor.formatOnSave": true,
        "editor.codeActionsOnSave": {
            "source.organizeImports": true
        },
        "editor.suggest.snippetsPreventQuickSuggestions": false
    },
    
    "go.liveErrors": {
        "enabled": true,
        "delay": 500
    },
    "go.lintTool": "revive",
    "go.toolsManagement.autoUpdate": true,
    "telemetry.enableTelemetry": false,
    "telemetry.enableCrashReporter": false,
    "gopls": {

        "usePlaceholders": true, // add parameter placeholders when completing a function
    },
}

I've tried uninstalling Go and reinstalling it from scratch and this has not solved the problem.

I've spent ages trying to get Go to work properly on my Mac with VS Code, but am close to giving up and trying Goland. Any suggestions?

[stamblerre]

@OscarVanL: Please take a look at the Troubleshooting guide and open a new issue if that doesn't help you solve the problem.

[IzhakJakov]

Why does he needs to open a new issue??
This is a problem with the plugin suggesting to do something that does not work anymore and refers me to this issue for more information.
If he opens a new issue, then, the plugin should refer me to that new issue instead of this one.