Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: support x/playground tests that need additional dependencies #66002

Open
dmitshur opened this issue Feb 28, 2024 · 2 comments
Open

x/build: support x/playground tests that need additional dependencies #66002

dmitshur opened this issue Feb 28, 2024 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@dmitshur
Copy link
Contributor

Right now the x/playground repo is tested via the usual go test ./... as other x/ repos.
As described in #24823, there are tests that need additional dependencies to run (Docker).
This is the tracking issue for that.

CC @golang/tools-team.

@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Feb 28, 2024
@dmitshur dmitshur added this to the Unreleased milestone Feb 28, 2024
@findleyr
Copy link
Member

As described in #69403, while I think we should support Dockerized tests for some projects such as vscode-go or pkgsite, my intuition is that an the playground relies on Docker more than it really needs to (it's just running the go command, after all!). We should probably address this issue by removing Docker from the development and test flow in x/playground.

@dmitshur
Copy link
Contributor Author

Agreed – if achieving x/playground's testing needs can be made to work without the Docker dependency, that path would be great. Recently @hyangah is exploring a similar direction for vscode-go's tests, tracked in golang/vscode-go#3533.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

2 participants