Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/telemetry/crashmonitor: fixup inaccurate locations in sigpanic stacks #70885

Open
findleyr opened this issue Dec 17, 2024 · 1 comment
Open
Labels
telemetry x/telemetry issues
Milestone

Comments

@findleyr
Copy link
Member

As described in #70637 (comment), the current behavior of crash output isn't quite correct for usage with runtime.CallersFrames: for runtime.sigpanic frames, we need to increment the PC of the next frame to get the correct location.

This issue tracks implementing this workaround in x/telemetry/crashmonitor.

In the future, we hope that debug.SetCrashOutput will support structured output, so that we can remove this fix.

@findleyr findleyr added this to the gopls/v0.18.0 milestone Dec 17, 2024
@gabyhelp
Copy link

Related Issues

Related Code Changes

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@gopherbot gopherbot added the telemetry x/telemetry issues label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
telemetry x/telemetry issues
Projects
None yet
Development

No branches or pull requests

3 participants