From a76cee4d947186be1e24f699fa1b257a368ec687 Mon Sep 17 00:00:00 2001 From: Tim King Date: Thu, 12 Sep 2024 16:30:13 -0700 Subject: [PATCH] cmd/vulncheck_compare: missing error branch Execution continued when `err != nil` and `binResp == nil`. This was causing flakes on the LUCI builders Change-Id: Ib3f9086b8315fc36b72745900720a572f2fbecce Reviewed-on: https://go-review.googlesource.com/c/pkgsite-metrics/+/612915 LUCI-TryBot-Result: Go LUCI Reviewed-by: Zvonimir Pavlinovic --- cmd/govulncheck_compare/govulncheck_compare.go | 1 + 1 file changed, 1 insertion(+) diff --git a/cmd/govulncheck_compare/govulncheck_compare.go b/cmd/govulncheck_compare/govulncheck_compare.go index 72959c0..6a9b80a 100644 --- a/cmd/govulncheck_compare/govulncheck_compare.go +++ b/cmd/govulncheck_compare/govulncheck_compare.go @@ -75,6 +75,7 @@ func run(w io.Writer, args []string) { binResp, err := govulncheck.RunGovulncheckCmd(govulncheckPath, govulncheck.FlagBinary, binary.BinaryPath, modulePath, vulndbPath) if err != nil { pair.Error = err.Error() + continue } pair.BinaryResults = *binResp pair.BinaryResults.Stats.BuildTime = binary.BuildTime