Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: require go 1.21+ for tools installation #3411

Open
hyangah opened this issue May 28, 2024 · 2 comments
Open

all: require go 1.21+ for tools installation #3411

hyangah opened this issue May 28, 2024 · 2 comments
Milestone

Comments

@hyangah
Copy link
Contributor

hyangah commented May 28, 2024

The upcoming gopls requires go1.21+ for installation.
golang/go#65917

Update the min version in the README and tools installation logic.

@hyangah hyangah added this to the v0.42.0 milestone May 28, 2024
@gopherbot gopherbot modified the milestones: v0.42.0, Untriaged May 28, 2024
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/588757 mentions this issue: extension/src: require go1.19+ for tools installation

gopherbot pushed a commit that referenced this issue May 29, 2024
Gopls v0.15.x requires go 1.19 or newer.
Update the README and the installation error message
to clarify the extension requires go 1.19+.

Gopls v0.16+ will require go 1.21+.
The next staticcheck will require go 1.22+. If go1.21
is used, `go install` will be able to pick up go 1.22,
so effectively, the extension does not have to worry
about tool's go version requirement any more if the
go version used for tools installation is go 1.21+.

Encode these version mapping metrix in goTools.ts and
installtools script.

Run go run tools/generate.go -tools
 that updates gopls latest version.

Fixes #3409
For #3411

Change-Id: Ib8177cda8c79a7251cb11f26ea3def18630f3858
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/588757
Commit-Queue: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Suzy Mueller <[email protected]>
kokoro-CI: kokoro <[email protected]>
@findleyr findleyr modified the milestones: Untriaged, v0.42.0 Jun 6, 2024
@findleyr
Copy link
Contributor

findleyr commented Jun 6, 2024

Putting this in the v0.42.0 milestone. @hyangah please remilestone if that is incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants