Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow paralleltest setting "ignoreloopVar" #4511

Closed
yolocs opened this issue Mar 15, 2024 · 2 comments
Closed

Allow paralleltest setting "ignoreloopVar" #4511

yolocs opened this issue Mar 15, 2024 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@yolocs
Copy link

yolocs commented Mar 15, 2024

Your feature request related to a problem? Please describe.

Per Go 1.22 (tip.golang.org/doc/go1.22), reinitialize loop (range) variable is no longer needed. https://github.com/kunwardeep/paralleltest has merged PR to add setting ignoreloopVar to ignore this check. But the setting is not yet available from golangci-lint setting (see: https://github.com/golangci/golangci-lint/blob/master/jsonschema/golangci.jsonschema.json#L2143).

Describe the solution you'd like.

Support paralleltest ignoreloopVar setting

Describe alternatives you've considered.

N/A

Additional context.

No response

@yolocs yolocs added the enhancement New feature or improvement label Mar 15, 2024
Copy link

boring-cyborg bot commented Mar 15, 2024

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

@ldez ldez added duplicate This issue or pull request already exists and removed enhancement New feature or improvement labels Mar 15, 2024
@ldez
Copy link
Member

ldez commented Mar 15, 2024

duplicate of #4405

@ldez ldez closed this as completed Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants