We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If TLS enabled and we got tlsHandshakeTimeoutError, we will not close TLS connection here
I suggest next improvements:
innerCtx, cancel := context.WithCancel(ctx) // new if d := do.tlsHandshakeTimeout; d != 0 { timer := time.AfterFunc(d, func() { cancel() errc <- tlsHandshakeTimeoutError{} }) defer timer.Stop() } go func() { errc <- tlsConn.HandshakeContext(innerCtx) // new }()
If we got timeout, TLS package close connection by cancel ctx here.
I think it's easiest solution of connection leak
The text was updated successfully, but these errors were encountered:
Looks reasonable @Oleglacto happy to take a PR.
Sorry, something went wrong.
How to make pr? I can't push into rep
You create a fork, push to your fork on a new branch e.g. fix/tls-close then raise a PR from that.
fix/tls-close
No branches or pull requests
If TLS enabled and we got tlsHandshakeTimeoutError, we will not close TLS connection here
I suggest next improvements:
If we got timeout, TLS package close connection by cancel ctx here.
I think it's easiest solution of connection leak
The text was updated successfully, but these errors were encountered: