-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal Proxy Cookies & docker-latest #80
Comments
Hi @tamaskan! Let me look into it shortly. Thank you for spotting this possible improvement. As for the Docker tags, |
Shouldn't they have the same digest then ? https://hub.docker.com/r/goniszewski/grimoire/tags |
As I can see in the CI log on GitHub, the push to the |
Thanks for clarifying. I was wondering why the package.json on main is still on 0.2.6 ( https://github.com/goniszewski/grimoire/blob/main/package.json ) |
@tamaskan it should be updated automatically, but for some reason wasn't. I looked into the documentation, and it looks like cookies are always passed to the proxy request. We don't need to overwrite them. Or maybe do you have something different in mind? |
I think i found my issue. In pb.ts it seems that only an internal pocketbase-installation can be used when is_dev is true |
I see there's a wrong port being specified for the default on DEV: should be It's now fixed on As for the logic behind PB URLs for specified environments:
|
I see. My problem is that executing an internal call to <PUBLIC_ORIGIN>/internal/pb is missing the cookies to bypass the sso on this url |
Ok, I thought it was a problem with the auth cookie for PocketBase auth. We can add some way to inject additional headers. The simplest solution would be to store stringified representation of additional headers in |
that would be a beautiful solution :-) |
@tamaskan could you review the changes from the linked PR? If yes, it would be great to have your opinion on this implementation! |
isn't it missing the variable-assignment in dockerfile ? |
Yes, indeed 😄 Fixed! |
I was able to build the branch with "--no-cache" in Dockerfile (segfaulting without). |
@tamaskan the error you're referring to, |
According to https://stackoverflow.com/questions/47870786/express-proxy-api-calls-with-cookie it seems possible to add the cookies from the initial request to the proxy request, therefore enabling cookie-based sso
The :latest seems to point to version 0.26 (probably because of the breaking changes). That should be mentioned
The text was updated successfully, but these errors were encountered: