Skip to content

Conversation

@mo271
Copy link
Collaborator

@mo271 mo271 commented Jan 7, 2026

No description provided.

Co-authored-by: Calle Sönne <csonne@google.com>
@YaelDillies YaelDillies changed the title fix infinite_isWallSunSunPrime_of_disc_eq fix(Wikipedia/WallSunSun): assumes the discriminant is 0 or 1 mod 4 Jan 7, 2026
@YaelDillies YaelDillies changed the title fix(Wikipedia/WallSunSun): assumes the discriminant is 0 or 1 mod 4 fix(Wikipedia/WallSunSun): assume the discriminant is 0 or 1 mod 4 Jan 7, 2026
@YaelDillies YaelDillies added awaiting-author The author should answer a question or perform changes. Reply when done. ams-11: Number theory labels Jan 7, 2026
@YaelDillies YaelDillies removed the awaiting-author The author should answer a question or perform changes. Reply when done. label Jan 9, 2026
@YaelDillies YaelDillies enabled auto-merge (squash) January 9, 2026 18:12
@mo271 mo271 disabled auto-merge January 9, 2026 18:18
@YaelDillies YaelDillies enabled auto-merge (squash) January 9, 2026 18:22
Copy link
Collaborator

@callesonne callesonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YaelDillies YaelDillies merged commit 3bf4a29 into google-deepmind:main Jan 9, 2026
6 checks passed
{p : ℕ | ∃ a b : ℕ, a ^ 2 - 4 * b = D ∧ IsLucasWieferichPrime a b p }.Infinite := by
theorem infinite_isWallSunSunPrime_of_disc_eq {D : ℕ} (hD₀ : 0 < D)
(hD : D ≡ 0 [MOD 4] ∨ D ≡ 1 [MOD 4]) :
{p : ℕ | ∃ a b : ℕ, a ^ 2 - 4 * b = D ∧ IsLucasWieferichPrime a b p}.Infinite := by
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be integer subtraction instead of nat subtraction?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't change the mathematical content since D > 0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have D>0 in the first place? I don't see it in the english.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a mess. The Wikipedia conjecture is unsourced, and I cannot find back the source in an hour of searching... In the future we should enforce that conjectures are sourced

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is that we added the condition ourselves to avoid this being incorrect when the subtraction truncates.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this seems wrong. D is supposed to be the discriminant of a quadratic field, so it certainly cannot be a square

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants