Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command and state format differences in traits #2

Open
casper2002casper opened this issue Dec 20, 2020 · 1 comment
Open

Command and state format differences in traits #2

casper2002casper opened this issue Dec 20, 2020 · 1 comment

Comments

@casper2002casper
Copy link

States use oneOf to indicate there are multiple types while commands seem to use separate files instead. Could this be homologated as it's a bit annoying and confusing to have to work with both formats.

@proppy
Copy link
Collaborator

proppy commented Jan 12, 2021

states schema also specify the response to the QUERY intent so in that sense they should be able to describe all the states supported by the device (hence the oneOf when states can vary depending on attributes).

Would it be helpful to have dedicated per-command states schema in order to distinguish which state are affected by which command similar to what we already do with results (ex: https://github.com/actions-on-google/smart-home-schema/blob/master/traits/networkcontrol/getguestnetworkpassword.results.schema.json)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants