Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the reproducible workflow behavior #151

Open
jmichelp opened this issue Sep 16, 2020 · 0 comments
Open

Modify the reproducible workflow behavior #151

jmichelp opened this issue Sep 16, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@jmichelp
Copy link
Collaborator

jmichelp commented Sep 16, 2020

Expected Behavior

We should have 2 different workflows:

  1. On each PR, build twice the firmware for each operating system, removing the crypto_data directory and copying the sample_crypto_data between the two builds and ensure that the hashes remain the same. This should block PR and tell us that we have something wrong.
  2. On merge, instead of checking the hashes against a reference, this should generate the new hashes and text outputs and automatically push a new commit with the this as a reference.

Actual Behavior

Currently the two behaviors are mixed up and don't allow us to stop when a build is actually not reproducible.

Steps to Reproduce the Problem

N/A

Specifications

  • Version: N/A
  • Platform: N/A
@jmichelp jmichelp added the enhancement New feature or request label Sep 16, 2020
@gendx gendx removed their assignment Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants