Skip to content

Commit 167a92f

Browse files
giulio-leoneCopilot
andcommitted
refactor: simplify state delta extraction to conditional expression
Addresses review feedback: use a single conditional expression instead of separate variable initializations and if block. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 2a65722 commit 167a92f

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

src/google/adk/sessions/database_session_service.py

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -554,15 +554,13 @@ async def append_event(self, session: Session, event: Event) -> Event:
554554
# write locks. Most events carry only session-scoped state (or no
555555
# state at all), so acquiring FOR UPDATE on app_states / user_states
556556
# unnecessarily serializes all concurrent append_event calls.
557-
has_app_delta = False
558-
has_user_delta = False
559-
state_deltas = None
560-
if event.actions and event.actions.state_delta:
561-
state_deltas = _session_util.extract_state_delta(
562-
event.actions.state_delta
563-
)
564-
has_app_delta = bool(state_deltas.get("app"))
565-
has_user_delta = bool(state_deltas.get("user"))
557+
state_deltas = (
558+
_session_util.extract_state_delta(event.actions.state_delta)
559+
if event.actions and event.actions.state_delta
560+
else None
561+
)
562+
has_app_delta = bool(state_deltas and state_deltas.get("app"))
563+
has_user_delta = bool(state_deltas and state_deltas.get("user"))
566564

567565
storage_app_state = await _select_required_state(
568566
sql_session=sql_session,

0 commit comments

Comments
 (0)