Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suspend functions to evaluate fhirpath expressions #2678

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Suspend functions to evaluate fhirpath expressions #2678

wants to merge 1 commit into from

Conversation

LZRS
Copy link
Collaborator

@LZRS LZRS commented Sep 26, 2024

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2677

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

MJ1998
MJ1998 requested changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@MJ1998 MJ1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually what I notice is that these "non-suspend" functions are being invoked from suspend functions only.

So instead of making each function suspend what if we make the source of flow to run on default dispatcher ? In class QuestionnaireViewModel, we could add flowOn operator to the questionnaireStateFlow

@LZRS
Copy link
Collaborator Author

LZRS commented Oct 7, 2024

Actually what I notice is that these "non-suspend" functions are being invoked from suspend functions only.

So instead of making each function suspend what if we make the source of flow to run on default dispatcher ? In class QuestionnaireViewModel, we could add flowOn operator to the questionnaireStateFlow

Okay, cool. I can try it out, not sure how we will handle passing testDispatcher for tests though. That is, in the QuestionnaireViewModelTest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MJ1998 MJ1998 MJ1998 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Android FHIR SDK
Status: PR under Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrap Fhirpath method evaluation calls to run from a different coroutineContext
2 participants
@LZRS @MJ1998