Add tests for semantic.GraphClause.String()

Author: aerostitch

bql/semantic/semantic_test.go

@@ -17,6 +17,7 @@ package semantic
 import (
 	"reflect"
 	"testing"
+	"time"
 
 	"github.com/google/badwolf/triple"
 	"github.com/google/badwolf/triple/literal"
@@ -96,6 +97,132 @@ func TestStatementAddData(t *testing.T) {
 	}
 }
 
+func TestGraphClauseString(t *testing.T) {
+	timeObj1 := time.Date(2019, 11, 20, 2, 30, 10, 5, time.UTC)
+	timeObj2 := time.Date(2019, 12, 3, 5, 40, 20, 7, time.UTC)
+	timeObj3 := time.Date(2019, 11, 30, 22, 10, 50, 3, time.UTC)
+	timeObj4 := time.Date(2019, 12, 2, 17, 0, 10, 15, time.UTC)
+	// Testing that NewNodeFromStrings is not the point of this package. Taking the example from the unit tests.
+	n, _ := node.NewNodeFromStrings("/some/type", "id_1")
+	// Testing NewImmutable is not the point of this package.
+	immutFoo, _ := predicate.NewImmutable("foo")
+	nO, _ := node.NewNodeFromStrings("/some/other/type", "id_2")
+	o := triple.NewNodeObject(nO)
+	table := []struct {
+		gc   *GraphClause
+		want string
+	}{
+		{&GraphClause{}, `{ opt=false @[][] }`},
+		{
+			&GraphClause{
+				Optional:         true,
+				S:                n,
+				SBinding:         "?nBinding",
+				SAlias:           "?nAlias",
+				STypeAlias:       "?nTypeAlias",
+				SIDAlias:         "?nIDAlias",
+				P:                immutFoo,
+				PID:              "?predID",
+				PBinding:         "?predBinding",
+				PAlias:           "?predAlias",
+				PIDAlias:         "?predIDAlias",
+				PAnchorBinding:   "?predAnchorBinding",
+				PAnchorAlias:     "?predAnchorAlias",
+				PLowerBound:      &timeObj1,
+				PUpperBound:      &timeObj2,
+				PLowerBoundAlias: "?earlyYesterday",
+				PUpperBoundAlias: "?someTimeInTheFuture",
+				PTemporal:        true,
+				O:                o,
+				OBinding:         "?objBinding",
+				OAlias:           "?objAlias",
+				OID:              "?objID",
+				OTypeAlias:       "?objTypeAlias",
+				OIDAlias:         "?objCuteID",
+				OAnchorBinding:   "?Popeyes",
+				OAnchorAlias:     "?Olive",
+				OLowerBound:      &timeObj3,
+				OUpperBound:      &timeObj4,
+				OLowerBoundAlias: "?SometimeSoon",
+				OUpperBoundAlias: "?seemsSoFarAway",
+				OTemporal:        true,
+			},
+			`{ opt=true /some/type<id_1> AS ?nAlias TYPE ?nTypeAlias ID ?nIDAlias "foo"@[] ?predBinding "?predID" AS ?predAlias ID ?predIDAlias AT ?predAnchorAlias /some/other/type<id_2> AS ?objAlias TYPE ?objTypeAlias ID ?objCuteID AT ?Olive AS ?objAlias ID ?objCuteID }`,
+		},
+		{
+			&GraphClause{
+				Optional:         true,
+				S:                nil,
+				SBinding:         "?nBinding",
+				SAlias:           "?nAlias",
+				STypeAlias:       "?nTypeAlias",
+				SIDAlias:         "?nIDAlias",
+				P:                nil,
+				PID:              "?predID",
+				PBinding:         "?predBinding",
+				PAlias:           "?predAlias",
+				PIDAlias:         "?predIDAlias",
+				PAnchorBinding:   "?predAnchorBinding",
+				PAnchorAlias:     "?predAnchorAlias",
+				PLowerBound:      &timeObj1,
+				PUpperBound:      &timeObj2,
+				PLowerBoundAlias: "?earlyYesterday",
+				PUpperBoundAlias: "?someTimeInTheFuture",
+				PTemporal:        false,
+				O:                nil,
+				OAnchorBinding:   "?Popeyes",
+				OLowerBound:      &timeObj3,
+				OUpperBound:      &timeObj4,
+				OLowerBoundAlias: "?SometimeSoon",
+				OUpperBoundAlias: "?seemsSoFarAway",
+				OTemporal:        false,
+			},
+			`{ opt=true ?nBinding AS ?nAlias TYPE ?nTypeAlias ID ?nIDAlias ?predBinding "?predID"@[] AS ?predAlias ID ?predIDAlias AT ?predAnchorAlias[] }`,
+		},
+		{
+			&GraphClause{
+				Optional:         true,
+				S:                nil,
+				SBinding:         "?nBinding",
+				SAlias:           "?nAlias",
+				STypeAlias:       "?nTypeAlias",
+				SIDAlias:         "?nIDAlias",
+				P:                nil,
+				PID:              "?predID",
+				PBinding:         "?predBinding",
+				PAlias:           "?predAlias",
+				PIDAlias:         "?predIDAlias",
+				PAnchorBinding:   "?predAnchorBinding",
+				PAnchorAlias:     "?predAnchorAlias",
+				PLowerBound:      &timeObj1,
+				PUpperBound:      &timeObj2,
+				PLowerBoundAlias: "?earlyYesterday",
+				PUpperBoundAlias: "?someTimeInTheFuture",
+				PTemporal:        true,
+				O:                nil,
+				OBinding:         "?objBinding",
+				OAlias:           "?objAlias",
+				OID:              "?objID",
+				OTypeAlias:       "?objTypeAlias",
+				OIDAlias:         "?objCuteID",
+				OAnchorAlias:     "?Olive",
+				OLowerBound:      &timeObj3,
+				OUpperBound:      &timeObj4,
+				OLowerBoundAlias: "?SometimeSoon",
+				OUpperBoundAlias: "?seemsSoFarAway",
+				OTemporal:        true,
+			},
+			`{ opt=true ?nBinding AS ?nAlias TYPE ?nTypeAlias ID ?nIDAlias ?predBinding "?predID"@[?predAnchorBinding at ?predAnchorAlias] AS ?predAlias ID ?predIDAlias AT ?predAnchorAlias ?objBinding "?objID"[2019-11-30T22:10:50.000000003Z,2019-12-02T17:00:10.000000015Z] AS ?objAlias TYPE ?objTypeAlias ID ?objCuteID AT ?Olive AS ?objAlias ID ?objCuteID }`,
+		},
+	}
+
+	for i, entry := range table {
+		if got, want := entry.gc.String(), entry.want; got != want {
+			t.Errorf("[case %d] failed; got %v, want %v", i, got, want)
+		}
+	}
+}
+
 func TestGraphClauseSpecificity(t *testing.T) {
 	table := []struct {
 		gc   *GraphClause