add bfbs-builtins requirement

thejtshow · Justin Davis · commit 2d8b99b60562 · 2025-08-29T08:47:42.000-04:00
diff --git a/src/flatc.cpp b/src/flatc.cpp
@@ -789,6 +789,13 @@ void FlatCompiler::ValidateOptions(const FlatCOptions &options) {
         "--cs-gen-json-serializer requires --gen-object-api to be set as "
         "well.");
   }
+
+  // wireshark generator requires `--bfbs-builtins` to get access to well-known
+  // attributes.
+  if (opts.lang_to_generate & IDLOptions::Language::kWireshark &&
+      !opts.binary_schema_builtins) {
+    Error("--bfbs-builtins must be set to generate Wireshark dissectors.");
+  }
 }
 
 flatbuffers::Parser FlatCompiler::GetConformParser(

Original file line number	Diff line number	Diff line change
`@@ -789,6 +789,13 @@ void FlatCompiler::ValidateOptions(const FlatCOptions &options) {`
`789`	`789`	`"--cs-gen-json-serializer requires --gen-object-api to be set as "`
`790`	`790`	`"well.");`
`791`	`791`	`}`
	`792`	`+`
	`793`	+ // wireshark generator requires `--bfbs-builtins` to get access to well-known
	`794`	`+ // attributes.`
	`795`	`+ if (opts.lang_to_generate & IDLOptions::Language::kWireshark &&`
	`796`	`+ !opts.binary_schema_builtins) {`
	`797`	`+ Error("--bfbs-builtins must be set to generate Wireshark dissectors.");`
	`798`	`+ }`
`792`	`799`	`}`
`793`	`800`
`794`	`801`	`flatbuffers::Parser FlatCompiler::GetConformParser(`