From 7c60f9de28fae40a08e6a633204a277aa7914720 Mon Sep 17 00:00:00 2001 From: Omar Jarjur Date: Thu, 15 Feb 2018 20:29:57 -0500 Subject: [PATCH] Fix a bug in the choice of comment hash. This fixes a bug in displaying comment threads where the hash shown for the thread (which is what a user would use for replying) was the hash of the current version of the comment, rather than the hash of the original comment. The hash of the original comment was already being correctly picked as the hash of the thread, but the code was incorrectly displaying something else in its place. --- commands/output/output.go | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/commands/output/output.go b/commands/output/output.go index 81b05735..4613cd38 100644 --- a/commands/output/output.go +++ b/commands/output/output.go @@ -150,11 +150,7 @@ func showSubThread(r *review.Review, thread review.CommentThread, indent string) } } comment := thread.Comment - threadHash, err := comment.Hash() - if err != nil { - return err - } - + threadHash := thread.Hash timestamp := reformatTimestamp(comment.Timestamp) commentSummary := fmt.Sprintf(indent+commentTemplate, threadHash, comment.Author, timestamp, statusString, comment.Description) indent = indent + " "