Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the repository.PullNotes command to remove a redundant call to "ls-remote" #28

Open
ojarjur opened this issue Jan 5, 2016 · 0 comments
Open

Change the repository.PullNotes command to remove a redundant call to "ls-remote" #28

ojarjur opened this issue Jan 5, 2016 · 0 comments
Labels
clean up

Comments

@ojarjur
Copy link
Collaborator

ojarjur commented Jan 5, 2016

As noted by @linquize here, the call to "ls-remote" in the PullNotes method is redundant; it follows a fetch of the remote refs, so they can just be listed locally instead of calling out to the remote repo again.
ojarjur referenced this issue Jan 5, 2016
@ojarjur
Changed the logic that calls into git to always cascade errors upwards.
d9f03ea 
Previously, we treated some errors as fatal if they were unrecoverable, and
used log.Fatal(...) to kill the program.

That old behavior was desirable when the code was simply being used by the
command-line tool, as it allowed us to catch unexpected errors very easily.
However, now that this code is being reused as a library, we should let the
caller decide how to treat unrecoverable errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clean up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ojarjur