You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The command below falsely succeeds, even though the filename or path is invalid: git appraise comment -f missspelled.go -m 'some message'
These comments seem to end up in the object referenced by .git/refs/notes/devtools/discuss and cause an error when listing with:
git appraise show <sha>> comments (2 threads):
> ... comment 1 ...
> fatal: Path 'missspelled.go' does not exist in'<sha>'
All comments, including the bad one, can be seen in the --json output.
It would also be nice to have guidance on editing/amending comments before pushing, since naively using git notes remove <sha> does not appear to work(?)
In the meantime I discovered that it was possible to checkout the comments into their own branch and remove the problem comment usinggit rebase --interactive:
git checkout -B comments refs/notes/devtools/discuss
git rebase -i HEAD~2
drop the commit, and manually fix the merge after git rebase --continue
git update-ref refs/notes/devtools/discuss comments
git checkout master
git branch -D comments
The text was updated successfully, but these errors were encountered:
Similarly there is no validation that the line number is within the length of the referenced file (should you accidentally add a line comment on the wrong file).
There are two different checks we need to put in place:
Make sure that the specified file and line exist at the time the comment is created.
Gracefully handle the file and/or line not existing when displaying a comment.
The second is required because a file and/or line might stop existing after a comment is written (if history is changed during the review), but we still want to be able to display those comments after such a thing happens.
The command below falsely succeeds, even though the filename or path is invalid:
git appraise comment -f missspelled.go -m 'some message'
These comments seem to end up in the object referenced by .git/refs/notes/devtools/discuss and cause an error when listing with:
All comments, including the bad one, can be seen in the
--json
output.It would also be nice to have guidance on editing/amending comments before pushing, since naively using
git notes remove <sha>
does not appear to work(?)In the meantime I discovered that it was possible to checkout the comments into their own branch and remove the problem comment using
git rebase --interactive
:The text was updated successfully, but these errors were encountered: