Address https://errorprone.info/bugpattern/ThreadPriorityCheck warnings.

RELNOTES=n/a
PiperOrigin-RevId: 686728364

Author: cpovirk

android/guava-testlib/test/com/google/common/testing/GcFinalizationTest.java

@@ -120,6 +120,7 @@ class Interruptenator extends Thread {
       this(interruptee, new AtomicBoolean(false));
     }
 
+    @SuppressWarnings("ThreadPriorityCheck") // TODO: b/175898629 - Consider onSpinWait.
     Interruptenator(final Thread interruptee, final AtomicBoolean shutdown) {
       super(
           new Runnable() {
@@ -135,6 +136,7 @@ public void run() {
       start();
     }
 
+    @SuppressWarnings("ThreadPriorityCheck") // TODO: b/175898629 - Consider onSpinWait.
     void shutdown() {
       shutdown.set(true);
       while (this.isAlive()) {

android/guava-tests/test/com/google/common/cache/CacheBuilderTest.java

@@ -466,6 +466,7 @@ public void run() {
    */
   @GwtIncompatible // QueuingRemovalListener
 
+  @SuppressWarnings("ThreadPriorityCheck") // TODO: b/175898629 - Consider onSpinWait.
   public void testRemovalNotification_clear_basher() throws InterruptedException {
     // If a clear() happens close to the end of computation, one of two things should happen:
     // - computation ends first: the removal listener is called, and the cache does not contain the

android/guava-tests/test/com/google/common/cache/CacheLoadingTest.java

@@ -2010,6 +2010,7 @@ public String load(String key) throws IOException, InterruptedException {
    * {@code getUnchecked}, and threads with an odd index will call {@code get}. If the cache throws
    * exceptions, this difference may be visible in the returned List.
    */
+  @SuppressWarnings("ThreadPriorityCheck") // TODO: b/175898629 - Consider onSpinWait.
   private static <K> List<Object> doConcurrentGet(
       final LoadingCache<K, ?> cache,
       final K key,
@@ -2248,6 +2249,7 @@ public void run() {
     assertEquals(refreshKey + suffix, map.get(refreshKey));
   }
 
+  @SuppressWarnings("ThreadPriorityCheck") // doing our best to test for races
   public void testExpandDuringLoading() throws InterruptedException {
     final int count = 3;
     final AtomicInteger callCount = new AtomicInteger();
@@ -2337,6 +2339,7 @@ public void run() {
   }
 
   // Test ignored because it is extremely flaky in CI builds
+  @SuppressWarnings("ThreadPriorityCheck") // doing our best to test for races
   public void
       ignoreTestExpandDuringRefresh()
       throws InterruptedException, ExecutionException {

android/guava-tests/test/com/google/common/cache/LocalCacheTest.java

@@ -558,6 +558,7 @@ public String load(String key) {
             }
 
             @Override
+            @SuppressWarnings("ThreadPriorityCheck") // TODO: b/175898629 - Consider onSpinWait.
             public ListenableFuture<String> reload(String key, String oldValue) {
               return refreshExecutor.submit(
                   () -> {

android/guava-tests/test/com/google/common/collect/QueuesTest.java

@@ -279,6 +279,7 @@ private void assertInterruptibleDrained(BlockingQueue<Object> q) {
   }
 
   // same as above; uninterruptible version
+  @SuppressWarnings("ThreadPriorityCheck") // TODO: b/175898629 - Consider onSpinWait.
   private void assertUninterruptibleDrained(BlockingQueue<Object> q) {
     assertEquals(0, Queues.drainUninterruptibly(q, ImmutableList.of(), 0, 10, MILLISECONDS));
 

android/guava-tests/test/com/google/common/util/concurrent/AbstractFutureBenchmarks.java

@@ -85,6 +85,7 @@ <T> Facade<T> newFacade() {
     abstract <T> Facade<T> newFacade();
   }
 
+  @SuppressWarnings("ThreadPriorityCheck") // TODO: b/175898629 - Consider onSpinWait.
   static void awaitWaiting(Thread t) {
     while (true) {
       Thread.State state = t.getState();

android/guava-tests/test/com/google/common/util/concurrent/AbstractFutureTest.java

@@ -1238,6 +1238,7 @@ public void run() {
       }
     }
 
+    @SuppressWarnings("ThreadPriorityCheck") // TODO: b/175898629 - Consider onSpinWait.
     void awaitWaiting() {
       while (!isBlocked()) {
         if (getState() == State.TERMINATED) {
@@ -1279,6 +1280,7 @@ public void run() {
       }
     }
 
+    @SuppressWarnings("ThreadPriorityCheck") // TODO: b/175898629 - Consider onSpinWait.
     void awaitWaiting() {
       while (!isBlocked()) {
         if (getState() == State.TERMINATED) {

android/guava-tests/test/com/google/common/util/concurrent/AbstractScheduledServiceTest.java

@@ -531,6 +531,7 @@ protected void runOneIteration() {}
             protected Scheduler scheduler() {
               return new CustomScheduler() {
                 @Override
+                @SuppressWarnings("ThreadPriorityCheck") // doing our best to test for races
                 protected Schedule getNextSchedule() throws Exception {
                   if (state() != State.STARTING) {
                     inGetNextSchedule.await();
@@ -555,6 +556,7 @@ public void testBig() throws Exception {
           protected Scheduler scheduler() {
             return new AbstractScheduledService.CustomScheduler() {
               @Override
+              @SuppressWarnings("ThreadPriorityCheck") // doing our best to test for races
               protected Schedule getNextSchedule() throws Exception {
                 // Explicitly yield to increase the probability of a pathological scheduling.
                 Thread.yield();

android/guava-tests/test/com/google/common/util/concurrent/AtomicDoubleArrayTest.java

@@ -161,6 +161,7 @@ public void testCompareAndSetInMultipleThreads() throws InterruptedException {
         newStartedThread(
             new CheckedRunnable() {
               @Override
+              @SuppressWarnings("ThreadPriorityCheck") // doing our best to test for races
               public void realRun() {
                 while (!a.compareAndSet(0, 2.0, 3.0)) {
                   Thread.yield();

android/guava-tests/test/com/google/common/util/concurrent/AtomicDoubleTest.java

@@ -104,6 +104,7 @@ public void testCompareAndSetInMultipleThreads() throws Exception {
         newStartedThread(
             new CheckedRunnable() {
               @Override
+              @SuppressWarnings("ThreadPriorityCheck") // doing our best to test for races
               public void realRun() {
                 while (!at.compareAndSet(2.0, 3.0)) {
                   Thread.yield();