Skip to content

Commit 164300e

Browse files
authored
Revert "Revert "Revert "namespace kctf zones by cluster name (#381)" (#427)" …"
This reverts commit fe8cd4c.
1 parent 6231b44 commit 164300e

File tree

2 files changed

+3
-13
lines changed

2 files changed

+3
-13
lines changed

dist/bin/kctf-cluster

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -647,7 +647,7 @@ function kctf_cluster_start_gce {
647647

648648
gcloud projects add-iam-policy-binding ${PROJECT} --member=serviceAccount:${DNS_GSA_EMAIL} --role=roles/dns.admin || return
649649

650-
"${KCTF_BIN}/kubectl" create configmap --namespace kctf-system external-dns --from-literal=DOMAIN_NAME=${DOMAIN_NAME} --from-literal=EMAIL_ADDRESS=${EMAIL_ADDRESS:-} --from-literal=CLUSTER_NAME=${CLUSTER_NAME:-} --dry-run=client -o yaml | "${KCTF_BIN}/kubectl" apply -f - || return
650+
"${KCTF_BIN}/kubectl" create configmap --namespace kctf-system external-dns --from-literal=DOMAIN_NAME=${DOMAIN_NAME} --from-literal=EMAIL_ADDRESS=${EMAIL_ADDRESS:-} --dry-run=client -o yaml | "${KCTF_BIN}/kubectl" apply -f - || return
651651
fi
652652

653653
if [[ "${DISABLE_SRC_RANGES}" == "0" ]]; then

kctf-operator/resources/external-dns.go

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -86,20 +86,10 @@ func NewExternalDnsDeployment() client.Object {
8686
Key: "DOMAIN_NAME",
8787
},
8888
},
89-
}, {
90-
Name: "CLUSTER_NAME",
91-
ValueFrom: &corev1.EnvVarSource{
92-
ConfigMapKeyRef: &corev1.ConfigMapKeySelector{
93-
LocalObjectReference: corev1.LocalObjectReference{
94-
Name: "external-dns",
95-
},
96-
Key: "CLUSTER_NAME",
97-
},
98-
},
99-
}, },
89+
}},
10090
Args: []string{"--log-level=debug", "--source=service", "--source=ingress",
10191
"--provider=google", "--domain-filter=$(DOMAIN_NAME)", "--registry=txt",
102-
"--txt-owner-id=kctf-cloud-dns-$(CLUSTER_NAME)"},
92+
"--txt-owner-id=kctf-cloud-dns"},
10393
},
10494
{
10595
Image: DOCKER_CERTBOT_IMAGE,

0 commit comments

Comments
 (0)