Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you tell me what's the meaning of magic and vt_type? #833

Closed
amone-bit opened this issue Dec 17, 2024 · 4 comments
Closed

Could you tell me what's the meaning of magic and vt_type? #833

amone-bit opened this issue Dec 17, 2024 · 4 comments

Comments

@amone-bit
Copy link

Image

@reyammer
Copy link
Collaborator

magic: what libmagic (the library behind file) would return for that content type (or the closest approximation of that). This is used as part of "backward compatibility". Note that since there were too many discrepancies, we have removed backward compatibility in 0.6.0+ (and thus we have removed magic entries as well).

vt_type: just an annotation on what's type used by VirusTotal for a given content type. This metadata is only used as part of the training and not really from any client, and that has been removed as well.

Anyways, noted down in #834 that we shoud improve the documentation of these aspects.

Closing this one; feel free to re-open in case you have follow up questions. Thanks!

@amone-bit
Copy link
Author

Thank you. And there are some content types' group seem to be null. Could you tell me the reason? The "avi" format in my opinion should be "video" group.
Image
Image

@amone-bit
Copy link
Author

amone-bit commented Dec 17, 2024

plus: Maybe this repository has some permission setting errors? I couldn't reopen this issue.
Image

@reyammer
Copy link
Collaborator

About group and other metadata: that json contains entries for many more content types that we actually support (and for many of them we don't / didn't have proper metadata), but we (should) have proper metadata for any supported by the model v1. That json is not really part of the API and should not be rely upon (and it has in fact been refactored in the new version).

About reopening issues: it turns out it's a "feature" from github, you can only reopen if you are a collaborator or if you closed the issue yourself (ref: https://github.com/orgs/community/discussions/41926#discussioncomment-6975082). I reopened it now, feel free to follow up or close it if all answers are clear.

Thanks!

@reyammer reyammer reopened this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants