Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert when the user has typed part of their password #20

Open
gerv opened this issue Apr 30, 2015 · 1 comment
Open

Alert when the user has typed part of their password #20

gerv opened this issue Apr 30, 2015 · 1 comment

Comments

@gerv
Copy link

gerv commented Apr 30, 2015

JavaScript keystroke logging can mean that even if the user never submits the form (after seeing the alert), the evil site gets the password anyway. This is presumably why the addon suggests users change their password even if the form hasn't been submitted.

This issue could be avoided, in some cases at least, for users whose passwords are sufficiently long and sufficiently random, by storing a hash of the first half of the password instead of the entire thing, and warning immediately after the first half is typed. That way, the attacker could get half the password using keylogging - but half of a random password isn't the whole thing, and it means that an immediate attack couldn't be mounted, as the attacker would have to bruteforce the other half. That gives the user time to change their password without worry.

This wouldn't need any extra UI; you could analyse the user's Google password for entropy and length to decide whether to enable this mode.

@adhintz adhintz changed the title Better protection against JS keylogging Alert when the user has typed part of their password May 4, 2015
@int-ua
Copy link

int-ua commented May 20, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants