From 61de000a1ba4d1f69485b678e89612fd279867b7 Mon Sep 17 00:00:00 2001 From: Chris Kennelly Date: Mon, 21 Oct 2024 09:55:28 -0700 Subject: [PATCH] Remove tests for want_no_hpaa. It is a no-op. PiperOrigin-RevId: 688173496 Change-Id: Ie12fb3eed0fdf81f3617fade0dbad6089088219b --- tcmalloc/BUILD | 11 --------- tcmalloc/testing/BUILD | 55 ------------------------------------------ 2 files changed, 66 deletions(-) diff --git a/tcmalloc/BUILD b/tcmalloc/BUILD index 90e5689f2..78ce69e60 100644 --- a/tcmalloc/BUILD +++ b/tcmalloc/BUILD @@ -349,17 +349,6 @@ cc_library( alwayslink = 1, ) -# TEMPORARY. WILL BE REMOVED. -# Add a dep to this if you want your binary to not use hugepage-aware -# allocator. -cc_library( - name = "want_no_hpaa", - copts = TCMALLOC_DEFAULT_COPTS, - visibility = [ - "//tcmalloc/testing:__pkg__", - ], -) - cc_library( # TODO(b/199203282, b/296281171): Remove this opt-out. name = "want_disable_huge_region_more_often", diff --git a/tcmalloc/testing/BUILD b/tcmalloc/testing/BUILD index d692ce0dd..85023d216 100644 --- a/tcmalloc/testing/BUILD +++ b/tcmalloc/testing/BUILD @@ -453,20 +453,6 @@ cc_binary( ], ) -cc_binary( - name = "want_hpaa_test_helper_32k_no_hpaa", - testonly = 1, - srcs = ["want_hpaa_test_helper.cc"], - copts = TCMALLOC_DEFAULT_COPTS, - malloc = "//tcmalloc:tcmalloc_large_pages", - deps = [ - "//tcmalloc:malloc_extension", - "//tcmalloc:want_no_hpaa", - "@com_google_absl//absl/log:check", - "@com_google_absl//absl/strings", - ], -) - cc_binary( name = "want_hpaa_test_helper_256k", testonly = 1, @@ -480,20 +466,6 @@ cc_binary( ], ) -cc_binary( - name = "want_hpaa_test_helper_256k_no_hpaa", - testonly = 1, - srcs = ["want_hpaa_test_helper.cc"], - copts = TCMALLOC_DEFAULT_COPTS, - malloc = "//tcmalloc:tcmalloc_256k_pages", - deps = [ - "//tcmalloc:malloc_extension", - "//tcmalloc:want_no_hpaa", - "@com_google_absl//absl/log:check", - "@com_google_absl//absl/strings", - ], -) - cc_binary( name = "want_hpaa_test_helper_hpaa", testonly = 1, @@ -507,19 +479,6 @@ cc_binary( ], ) -cc_binary( - name = "want_hpaa_test_helper_no_hpaa", - testonly = 1, - srcs = ["want_hpaa_test_helper.cc"], - copts = TCMALLOC_DEFAULT_COPTS, - deps = [ - "//tcmalloc:malloc_extension", - "//tcmalloc:want_no_hpaa", - "@com_google_absl//absl/log:check", - "@com_google_absl//absl/strings", - ], -) - cc_binary( name = "want_hpaa_test_helper_small", testonly = 1, @@ -533,20 +492,6 @@ cc_binary( ], ) -cc_binary( - name = "want_hpaa_test_helper_small_no_hpaa", - testonly = 1, - srcs = ["want_hpaa_test_helper.cc"], - copts = TCMALLOC_DEFAULT_COPTS, - malloc = "//tcmalloc:tcmalloc_small_but_slow", - deps = [ - "//tcmalloc:malloc_extension", - "//tcmalloc:want_no_hpaa", - "@com_google_absl//absl/log:check", - "@com_google_absl//absl/strings", - ], -) - create_tcmalloc_testsuite( name = "get_stats_test", srcs = ["get_stats_test.cc"],