Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIP-213: Recommend use of common types #1130

Open
noahdietz opened this issue Apr 5, 2023 · 0 comments
Open

AIP-213: Recommend use of common types #1130

noahdietz opened this issue Apr 5, 2023 · 0 comments
Labels
type: feature request

Comments

@noahdietz
Copy link
Collaborator

I often see the following fields during API review:

  • start_time/end_time
  • string color

These would be better represented using the common types we support e.g. google.type.Interval and google.type.Color respectively.

Perhaps we should add some rules to recommend those types when it looks like they are mimicking them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@noahdietz