Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-123: Handling of names for nested collections only considers immediate parent #1424

Open
SanjayVas opened this issue Aug 28, 2024 · 1 comment

Comments

@SanjayVas
Copy link

This is for core::0123::resource-pattern-singular and core::0123::resource-pattern-plural, and how AIP-123 interacts with affordance for nested collections in AIP-122.

I'm not entirely certain whether this is just a linter problem or also needs clarification in AIP-122. The basic issue is that the handling of nested collections only considers the parent, rather than all ancestors. e.g. if you have a top-level collection users, you should be able to shorten the pattern for any descendant resource type starting with User.

See #1408 and #1403.

@noahdietz
Copy link
Collaborator

Thanks for the feedback, I think this does need clarification in AIP-122 as you suggest. I don't want to mark this as a bug since it implemented what the guidance suggested, though the guidance is incomplete. It's a discussion worth having, but one that should be done around the guidance rather than the linter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants