Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linkify in AIP-0148 UID-format #1280

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Linkify in AIP-0148 UID-format #1280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions docs/rules/0148/uid-format.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@ field, as mandated in [AIP-148][].
## Details

This rule looks on for fields named `uid` and complains if it does not have the
`(google.api.field_info).format = UUID4` annotation or has a format other than
`UUID4`.
`(google.api.field_info).format = UUID4` annotation or has a
[format](https://github.com/googleapis/googleapis/blob/master/google/api/field_info.proto#L54)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind doing a few things:

  1. Put this in a named link down at the bottom e.g. [format]: https://.... and changing this to [format][]
  2. Remove the Line number - when targeting master it is potentially inaccurate

Alternatively, just link to AIP-202 where all of the formats are described.

other than `UUID4`.

## Examples

Expand Down