Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gapic: remove client hook concept unless it is still used #1303

Open
noahdietz opened this issue Apr 17, 2023 · 1 comment
Open

gapic: remove client hook concept unless it is still used #1303

noahdietz opened this issue Apr 17, 2023 · 1 comment
Labels
type: cleanup An internal cleanup or hygiene concern.
Milestone
Go GAPIC Moderniz...

Comments

@noahdietz
Copy link
Collaborator

The clientHook feature added in #352 hasn't seen strong adoption by client teams. We should evaluate if it is still necessary and potentially remove it if not.
@noahdietz noahdietz added the type: cleanup An internal cleanup or hygiene concern. label Apr 17, 2023
@noahdietz noahdietz added this to the Go GAPIC Modernization milestone Apr 17, 2023
@noahdietz
Copy link
Collaborator Author

Currently only used by Spanner (added in googleapis/google-cloud-go@1ac32cb, code search query). Engaged with them on usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
Go GAPIC Modernization
Development

No branches or pull requests
1 participant
@noahdietz