Testing Issue: breaking changes related to grpc generator #1554
Labels
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Comments
shollyman
added
priority: p2
|
Great diagnosis, thank you! |
quartzmo
added a commit
to quartzmo/gapic-generator-go
that referenced
this issue
Aug 29, 2024
* upgrade bazel_gazelle to 0.38.0 * upgrade com_google_protobuf to 25.4 * add rules_proto 6.0.2 * remove -use_generic_streams_experimental * fix error: protoc-gen-go-grpc: no such flag -use_generic_streams_experimental refs: googleapis#1554
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As part of showcase testing in this generator, CI tests effectively compare a recent release of the showcase generated code to one that's output by the generator using apidiff.
The grpc plugin (https://pkg.go.dev/google.golang.org/grpc/cmd/protoc-gen-go-grpc) has a new option (
use_generic_streams_experimental) that recently defaulted to true. Because our showcase testing grabs the plugin latest version, we were picking up that new change.To resolve our immediate issue, we need to add the experimental flag to our build process to disable the newly enabled behavior, and verify what further actions are needed.
The text was updated successfully, but these errors were encountered: