Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include retry info in client and/or method docs #776

Open
tbpg opened this issue Sep 22, 2021 · 3 comments
Open

Include retry info in client and/or method docs #776

tbpg opened this issue Sep 22, 2021 · 3 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tbpg
Copy link
Contributor

tbpg commented Sep 22, 2021

It would be nice to have more information about retries in the GoDoc of the libraries:

  • What is retried by default?
  • How exactly do I configure retries?
@tbpg tbpg added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Sep 22, 2021
@codyoss
Copy link
Member

codyoss commented Sep 22, 2021

Is this something that could be in an overarching doc? It should be consistent between all clients.

@tbpg
Copy link
Contributor Author

tbpg commented Sep 22, 2021

It might change between versions. But, yes, I think it would make sense to put some info into an overarching doc. For now, if you ctrl+f for retry in the docs for one of our libraries, you don't really find anything helpful.

@noahdietz noahdietz added the priority: p3 Desirable enhancement or fix. May not be included in next release. label Dec 14, 2021
@codyoss
Copy link
Member

codyoss commented Dec 21, 2022

Maybe we could generate comments on the call options: https://pkg.go.dev/cloud.google.com/go/asset/apiv1#CallOptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@codyoss @noahdietz @tbpg