Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RPCs to verify unknown numeric enums in path params and body #1212

Open
blakeli0 opened this issue Sep 8, 2022 · 1 comment
Open

Add RPCs to verify unknown numeric enums in path params and body #1212

blakeli0 opened this issue Sep 8, 2022 · 1 comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@blakeli0
Copy link
Contributor

blakeli0 commented Sep 8, 2022

The current VerifyEnum works great for asserting that unknown numeric enums should be passed in as numbers, but it's only for enums in query params. We can add two more RPCs to verify unknown numeric enums in path params and body.
The RPCs may look like this

rpc VerifyEnumPath(EnumResponse) returns (EnumResponse) {
  option (google.api.http) = {
    post: "/v1beta1/compliance/enum/{continent}"
  };
}

rpc VerifyEnumBody(EnumResponse) returns (EnumResponse) {
    option (google.api.http) = {
      post: "/v1beta1/compliance/enum"
      body: "*"
    };
  }
@blakeli0 blakeli0 added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Sep 8, 2022
@vchudnov-g vchudnov-g added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p3 Desirable enhancement or fix. May not be included in next release. labels Sep 9, 2022
@callmetushar123
Copy link

callmetushar123 commented Sep 16, 2022

@vchudnov-g can you please assign me this issue? I think would be a good first issue for me as I am new to open source contributing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants