Skip to content

Conversation

@Yuan325
Copy link
Contributor

@Yuan325 Yuan325 commented Nov 18, 2025

Description

Temporarily move server.json out from the .registry/ folder. The mcp-publisher library do not support the --file flag yet. A PR was submitted to add flags for publish subcommand.

PR Checklist

Thank you for opening a Pull Request! Before submitting your PR, there are a
few things you can do to make sure it goes smoothly:

  • Make sure you reviewed
    CONTRIBUTING.md
  • Make sure to open an issue as a
    bug/issue
    before writing your code! That way we can discuss the change, evaluate
    designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Make sure to add ! if this involve a breaking change

🛠️ Fixes #<issue_number_goes_here>

@Yuan325 Yuan325 requested a review from a team as a code owner November 18, 2025 21:42
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Yuan325, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a temporary workaround for a known limitation in the mcp-publisher library. By relocating the server.json configuration file to the root directory, it ensures that the publishing process can proceed without issues until the library is updated to support custom file paths. This change is explicitly temporary, pending the resolution of the upstream library's functionality.

Highlights

  • File Relocation: The server.json file has been temporarily moved from its original location within the .registry/ folder to the project's root directory. This change is a temporary measure to accommodate a limitation in the mcp-publisher library.
  • Library Workaround: This relocation serves as a workaround because the mcp-publisher library currently does not support specifying the configuration file path using a --file flag. A pull request has been submitted to address this limitation in the library.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/publish-mcp.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Yuan325 Yuan325 changed the title chore: temporarily move server.json to root chore(mcp-registry): temporarily move server.json to root Nov 18, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request relocates the server.json file to the project's root directory. This change is a temporary workaround to ensure compatibility with the mcp-publisher library, as noted in the description. The move is straightforward and doesn't appear to introduce any regressions in the provided codebase. While reviewing the moved file, I noticed that the version number is hardcoded in two separate places within server.json. To improve long-term maintainability and prevent potential inconsistencies when the version is updated, it would be beneficial to address this duplication in a future change.

@Yuan325 Yuan325 assigned Yuan325 and averikitsch and unassigned duwenxin99 and Yuan325 Nov 18, 2025
@Yuan325 Yuan325 merged commit 88caf73 into main Nov 18, 2025
13 of 15 checks passed
@Yuan325 Yuan325 deleted the registry-temp-updates branch November 18, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants