Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using GOOGLE_CLOUD_CPP_STORAGE_ENABLE_GRPC results in an error without a deprecation diagnostic. #15046

Open
scotthart opened this issue Mar 24, 2025 · 0 comments
Open

Using GOOGLE_CLOUD_CPP_STORAGE_ENABLE_GRPC results in an error without a deprecation diagnostic. #15046

scotthart opened this issue Mar 24, 2025 · 0 comments
Assignees
@ddelgrosso1
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@scotthart
Copy link
Member

As evidenced by #15045, a diagnostic indicating that GOOGLE_CLOUD_CPP_STORAGE_ENABLE_GRPC has been deprecated and that DGOOGLE_CLOUD_CPP_ENABLE=storage_grpc should be used instead is not being emitted.

While we have such a message describing the option

google-cloud-cpp/cmake/GoogleCloudCppFeatures.cmake

Line 512 in b25d354

"Enable compilation for the GCS gRPC plugin (EXPERIMENTAL). Deprecated, prefer GOOGLE_CLOUD_CPP_ENABLE."
, we should try and display a similar message when the option is used.
@scotthart scotthart added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddelgrosso1 ddelgrosso1

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scotthart @ddelgrosso1