Skip to content

Commit 61435be

Browse files
daniel-sanchegkevinzhenggcf-owl-bot[bot]
authored
tests(bigtable): System/compatibility tests for testing shim compatiblity (#17901)
Migrating over @gkevinzheng PR from bigtable monorepo googleapis/python-bigtable#1218 Original description: > Additional system tests for testing shim compatibility with the classic client interface. > >Also fixes a bug where encountering a retriable error after another retriable error mid-stream raised an exception instead of retrying. > > Fixes googleapis/python-bigtable#1156 Note to reviewers: This PR has already been reviewed and merged to a staging branch, with the intention of doing a single merge to main. We are now planning to slowly rollout these changes back to the main branch. Minimal re-review should be necessary --------- Co-authored-by: Kevin Zheng <147537668+gkevinzheng@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent 7e2e23e commit 61435be

2 files changed

Lines changed: 844 additions & 4 deletions

File tree

packages/google-cloud-bigtable/google/cloud/bigtable/row_data.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ def _on_error(self, exc):
224224
retry_request = self._create_retry_request()
225225

226226
self._row_merger = _RowMerger(self._row_merger.last_seen_row_key)
227-
self.response_iterator = self.read_method(retry_request)
227+
self.response_iterator = self.read_method(retry_request, retry=self.retry)
228228

229229
def _read_next(self):
230230
"""Helper for :meth:`__iter__`."""

0 commit comments

Comments
 (0)