Skip to content

Commit 895ffa2

Browse files
authored
fix(generator): switch core_deps_from_source to DEFAULT_PYTHON_VERSION (#18050)
Update `core_deps_from_source` nox sessions in the noxfile template and integration test goldens to run on `DEFAULT_PYTHON_VERSION` instead of `PREVIEW_PYTHON_VERSION`. Running against unreleased preview Python versions causes CI failures due to missing prebuilt wheels on PyPI for third-party dependencies.
1 parent c03b273 commit 895ffa2

10 files changed

Lines changed: 11 additions & 11 deletions

File tree

.github/workflows/gapic-generator-tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ jobs:
133133
pip install nox
134134
cd packages/gapic-generator
135135
for pkg in credentials eventarc logging redis; do
136-
nox -f tests/integration/goldens/$pkg/noxfile.py -s format lint unit-${LATEST_STABLE_PYTHON}
136+
nox -f tests/integration/goldens/$pkg/noxfile.py -s format lint unit-${LATEST_STABLE_PYTHON} core_deps_from_source
137137
done
138138
# Run pylint (errors-only) over the goldens so generator regressions
139139
# like undefined names or import-time breakage that ruff/flake8 do
@@ -171,7 +171,7 @@ jobs:
171171
pip install nox
172172
cd packages/gapic-generator
173173
for pkg in credentials eventarc logging redis; do
174-
nox -f tests/integration/goldens/$pkg/noxfile.py -s core_deps_from_source prerelease_deps
174+
nox -f tests/integration/goldens/$pkg/noxfile.py -s prerelease_deps
175175
done
176176
177177
fragment-snippet:

packages/gapic-generator/gapic/templates/noxfile.py.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -572,7 +572,7 @@ def prerelease_deps(session, protobuf_implementation):
572572
)
573573

574574

575-
@nox.session(python=PREVIEW_PYTHON_VERSION)
575+
@nox.session(python=DEFAULT_PYTHON_VERSION)
576576
@nox.parametrize(
577577
"protobuf_implementation",
578578
["python", "upb"],

packages/gapic-generator/tests/integration/goldens/asset/noxfile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -564,7 +564,7 @@ def prerelease_deps(session, protobuf_implementation):
564564
)
565565

566566

567-
@nox.session(python=PREVIEW_PYTHON_VERSION)
567+
@nox.session(python=DEFAULT_PYTHON_VERSION)
568568
@nox.parametrize(
569569
"protobuf_implementation",
570570
["python", "upb"],

packages/gapic-generator/tests/integration/goldens/credentials/noxfile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -564,7 +564,7 @@ def prerelease_deps(session, protobuf_implementation):
564564
)
565565

566566

567-
@nox.session(python=PREVIEW_PYTHON_VERSION)
567+
@nox.session(python=DEFAULT_PYTHON_VERSION)
568568
@nox.parametrize(
569569
"protobuf_implementation",
570570
["python", "upb"],

packages/gapic-generator/tests/integration/goldens/eventarc/noxfile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -564,7 +564,7 @@ def prerelease_deps(session, protobuf_implementation):
564564
)
565565

566566

567-
@nox.session(python=PREVIEW_PYTHON_VERSION)
567+
@nox.session(python=DEFAULT_PYTHON_VERSION)
568568
@nox.parametrize(
569569
"protobuf_implementation",
570570
["python", "upb"],

packages/gapic-generator/tests/integration/goldens/logging/noxfile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -564,7 +564,7 @@ def prerelease_deps(session, protobuf_implementation):
564564
)
565565

566566

567-
@nox.session(python=PREVIEW_PYTHON_VERSION)
567+
@nox.session(python=DEFAULT_PYTHON_VERSION)
568568
@nox.parametrize(
569569
"protobuf_implementation",
570570
["python", "upb"],

packages/gapic-generator/tests/integration/goldens/logging_internal/noxfile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -564,7 +564,7 @@ def prerelease_deps(session, protobuf_implementation):
564564
)
565565

566566

567-
@nox.session(python=PREVIEW_PYTHON_VERSION)
567+
@nox.session(python=DEFAULT_PYTHON_VERSION)
568568
@nox.parametrize(
569569
"protobuf_implementation",
570570
["python", "upb"],

packages/gapic-generator/tests/integration/goldens/redis/noxfile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -564,7 +564,7 @@ def prerelease_deps(session, protobuf_implementation):
564564
)
565565

566566

567-
@nox.session(python=PREVIEW_PYTHON_VERSION)
567+
@nox.session(python=DEFAULT_PYTHON_VERSION)
568568
@nox.parametrize(
569569
"protobuf_implementation",
570570
["python", "upb"],

packages/gapic-generator/tests/integration/goldens/redis_selective/noxfile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -564,7 +564,7 @@ def prerelease_deps(session, protobuf_implementation):
564564
)
565565

566566

567-
@nox.session(python=PREVIEW_PYTHON_VERSION)
567+
@nox.session(python=DEFAULT_PYTHON_VERSION)
568568
@nox.parametrize(
569569
"protobuf_implementation",
570570
["python", "upb"],

packages/gapic-generator/tests/integration/goldens/storagebatchoperations/noxfile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -564,7 +564,7 @@ def prerelease_deps(session, protobuf_implementation):
564564
)
565565

566566

567-
@nox.session(python=PREVIEW_PYTHON_VERSION)
567+
@nox.session(python=DEFAULT_PYTHON_VERSION)
568568
@nox.parametrize(
569569
"protobuf_implementation",
570570
["python", "upb"],

0 commit comments

Comments
 (0)