remove extra clones and test cases

Author: suzmue

src/integration-tests/src/pubsub.rs

@@ -43,9 +43,9 @@ pub async fn basic_topic(builder: pubsub::builder::topic_admin::ClientBuilder) -
         .send()
         .await?;
     tracing::info!("success with list_topics={topics:?}");
-    assert!(topics.topics.iter().any(|x| x.name == topic.name.clone()));
+    assert!(topics.topics.iter().any(|x| x.name == topic.name));
 
-    cleanup_test_topic(topic_admin, topic.name.clone()).await?;
+    cleanup_test_topic(topic_admin, topic.name).await?;
 
     Ok(())
 }
@@ -68,12 +68,12 @@ pub async fn create_test_topic() -> Result<(TopicAdmin, Topic)> {
         .with_tracing()
         .build()
         .await?;
-    let topic_id = random_topic_id(project.clone());
+    let topic_id = random_topic_id(project);
 
     tracing::info!("testing create_topic()");
     let topic = client
         .create_topic()
-        .set_name(topic_id.clone())
+        .set_name(topic_id)
         .set_labels([("integration-test", "true")])
         .send()
         .await?;

src/integration-tests/tests/driver.rs

@@ -47,16 +47,13 @@ mod driver {
             .map_err(integration_tests::report_error)
     }
 
-    #[test_case(pubsub::client::TopicAdmin::builder(); "default")]
-    #[test_case(pubsub::client::TopicAdmin::builder().with_tracing(); "with tracing enabled")]
-    #[test_case(pubsub::client::TopicAdmin::builder().with_retry_policy(retry_policy()); "with retry enabled")]
     #[tokio::test(flavor = "multi_thread", worker_threads = 1)]
-    async fn run_pubsub_basic_topic(
-        builder: pubsub::builder::topic_admin::ClientBuilder,
-    ) -> integration_tests::Result<()> {
-        integration_tests::pubsub::basic_topic(builder)
-            .await
-            .map_err(integration_tests::report_error)
+    async fn run_pubsub_basic_topic() -> integration_tests::Result<()> {
+        integration_tests::pubsub::basic_topic(
+            pubsub::client::TopicAdmin::builder().with_retry_policy(retry_policy()),
+        )
+        .await
+        .map_err(integration_tests::report_error)
     }
 
     #[test_case(sm::client::SecretManagerService::builder(); "default")]