Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enough well-known types to support google/api #605

Open
coryan opened this issue Jan 6, 2025 · 0 comments
Open

Add enough well-known types to support google/api #605

coryan opened this issue Jan 6, 2025 · 0 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@coryan
Copy link
Contributor

coryan commented Jan 6, 2025

Several services use the proto messages defined in google/api. These message use more well-known types than we anticipated, including protobuf descriptors, such as google.protobuf.Type:

  // A list of all proto message types included in this API service.
  // Types referenced directly or indirectly by the `apis` are automatically
  // included.  Messages which are not referenced but shall be included, such as
  // types used by the `google.protobuf.Any` type, should be listed here by
  // name by the configuration author. Example:
  //
  //     types:
  //     - name: google.protobuf.Int32
  repeated google.protobuf.Type types = 4;

https://github.com/googleapis/googleapis/blob/29aea4190aba664659908ff5e381c830e4752502/google/api/service.proto#L107C1-L115C43

It seems that only the name is needed, which may simplify the work. Other types (e.g. google.protobuf.Struct) may need a full implementation.

@coryan coryan added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant