impl: use gcp-sdk-lro as a named feature
#689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #689 +/- ##
=======================================
Coverage 95.73% 95.73%
=======================================
Files 33 33
Lines 1244 1244
=======================================
Hits 1191 1191
Misses 53 53 ☔ View full report in Codecov by Sentry. |
Now that the `gcp-sdk-lro` crate exists, configure `sidekick` to automatically add this as a dependency of any generated crate with LROs.
coryan
force-pushed
the
feat-lro-helpers-pr3
branch
from
f328d07 to
7786387
Compare
codyoss
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the
gcp-sdk-lrocrate exists, configuresidekicktoautomatically add this as a dependency of any generated crate with LROs.
Fixes #688