Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate client library for Bigtable Admin #712

Open
2 tasks
coryan opened this issue Jan 17, 2025 · 0 comments
Open
2 tasks

Generate client library for Bigtable Admin #712

coryan opened this issue Jan 17, 2025 · 0 comments
Labels
api: bigtableadmin Issues related to the Cloud Bigtable Admin API API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@coryan
Copy link
Contributor

coryan commented Jan 17, 2025

This is blocked by

The generated code fails to compile:

cargo new --lib --vcs none src/generated/bigtableadmin/v2
go -C generator/ run ./cmd/sidekick generate -project-root .. -specification-source google/bigtable/admin/v2 -service-config google/bigtable/admin/v2/bigtableadmin_v2.yaml -output src/generated/bigtableadmin/v2

Then cargo build gives you:

error[E0428]: the name `GetIamPolicy` is defined multiple times
    --> src/generated/bigtableadmin/v2/src/builders.rs:2803:1
     |
1032 | pub struct GetIamPolicy(BigtableInstanceAdminRequestBuilder<iam_v1::model::GetIamPolicyRequest>);
     | ------------------------------------------------------------------------------------------------- previous definition of the type `GetIamPolicy` here
...
2803 | pub struct GetIamPolicy(BigtableTableAdminRequestBuilder<iam_v1::model::GetIamPolicyRequest>);
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `GetIamPolicy` redefined here
     |
     = note: `GetIamPolicy` must be defined only once in the type namespace of this module

and

error[E0391]: cycle detected when computing when `model::r#type::Aggregate` needs drop
    --> src/generated/bigtableadmin/v2/src/model.rs:6793:5
     |
6793 |     pub struct Aggregate {
     |     ^^^^^^^^^^^^^^^^^^^^
     |
     = note: ...which immediately requires computing when `model::r#type::Aggregate` needs drop again
note: cycle used when computing when `model::ColumnFamily` needs drop
    --> src/generated/bigtableadmin/v2/src/model.rs:5502:1
     |
5502 | pub struct ColumnFamily {
     | ^^^^^^^^^^^^^^^^^^^^^^^
     = note: see https://rustc-dev-guide.rust-lang.org/overview.html#queries and https://rustc-dev-guide.rust-lang.org/query.html for more information
@coryan coryan added api: bigtableadmin Issues related to the Cloud Bigtable Admin API API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtableadmin Issues related to the Cloud Bigtable Admin API API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant