Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mismatched expiration time in service account credentials #733

Closed
coryan opened this issue Jan 17, 2025 · 0 comments · Fixed by #789
Closed

Mismatched expiration time in service account credentials #733

coryan opened this issue Jan 17, 2025 · 0 comments · Fixed by #789
Assignees
@dbolduc
Labels
auth Issues related to the auth library priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@coryan
Copy link
Contributor

coryan commented Jan 17, 2025

This is wrong:

google-cloud-rust/src/auth/src/credentials/service_account_credential.rs

Line 89 in d134811

expires_at: Some(OffsetDateTime::now_utc() + DEFAULT_TOKEN_TIMEOUT),

The expiration time should match the expiration time in the credentials, which is set to now - fudge + default. And there are two separate calls to utc_now() which may return different values.
@coryan coryan added auth Issues related to the auth library priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jan 17, 2025
@dbolduc dbolduc self-assigned this Jan 21, 2025
@dbolduc dbolduc mentioned this issue Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbolduc dbolduc

Labels
auth Issues related to the auth library priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(auth): sync claim/token times in SA creds dbolduc/google-cloud-rust
2 participants
@coryan @dbolduc