Unhandled exception when running parallel queries with first query as "invalid" in a transaction.

[surbhigarg92]

The Nodejs library does not handle below scenario, where the first query throws an error while trying to execute parallel queries in a transaction .

await database.runTransactionAsync(async tx => {
        try {
          await Promise.all([tx!.run(invalidSql), tx!.run(selectSql)]);
          await tx.commit();
        } catch (err) {
          console.log(err);
        }

Expected: The initial call to ExecuteStreamingSql should fail, which also means that there is no transaction ID that is returned. The transaction is retried with an explicit BeginTransaction and then the invalid SQL + working SQL statement are executed again. Error will be thrown from the invalid SQL statement.

Actual: The initial call to ExecuteStreamingSql fails which initiates a explicit BeginTransaction as per this code . But since this request is not awaited, error is thrown to the catch block and begin transaction continues in parallel , ultimately throwing unhandled exception.

[alkatrivedi]

@surbhigarg92 I am not able to reproduce the behavior(unhandled exception) using given code here.
To investigate the error handling, I ran below code where the first query is designed to fail:

await database.runTransactionAsync(async transaction => {
   await Promise.all([transaction?.run('SELECT * FROM FOO'), transaction?.run('SELECT * FROM Singers')]);
   await transaction.commit();
  });

and my observation is that code is behaving correctly. Instead of an unhandled exception, the transaction fails with an exepected INVALID_ARGUMENT error:
Error: 3 INVALID_ARGUMENT: Table not found: FOO [at 1:15]\nSELECT * FROM FOO\n

My analysis is that because INVALID_ARGUMENT is not a retryable error (like aborted), the AsyncTransactionRunner correctly decided not to retry the transaction and immediately throws the error. The main execution then terminates based on this thrown error - ref.

this behavior seems correct to me. please let me know if I've missed anything in this analysis.