Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make vertexai package PEP-561 compatible #4700

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vladimir-chernykh
Copy link

vertexai is typed inline very well but misses py.typed marker file. Type checkers (e.g. mypy) treats the package as untyped because of that.

This PR fixes it by adding simple py.typed file as it is done in other packages in this repo.

Fixes #4654 🦕

Copy link

conventional-commit-lint-gcf bot commented Nov 22, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels Nov 22, 2024
@vladimir-chernykh vladimir-chernykh changed the title Make vertexai package PEP-561 compatible chore: make vertexai package PEP-561 compatible Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding py.typed to repo to support type checking
1 participant