Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some unit tests require real credentials files #1279

Open
andrewsg opened this issue May 23, 2024 · 0 comments
Open

Some unit tests require real credentials files #1279

andrewsg opened this issue May 23, 2024 · 0 comments
Assignees
@andrewsg
Labels
api: storage Issues related to the googleapis/python-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@andrewsg
Copy link
Contributor

Some unit tests require credentials files to be present on the system, which is inappropriate for a unit test. The credentials should be mocked instead.

TestClient.test_create_bucket_w_custom_endpoint
TestClient.test_ctor_w_custom_endpoint_use_auth
TestClient.test_list_buckets_w_custom_endpoint
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label May 23, 2024
@frankyn frankyn assigned andrewsg and unassigned frankyn May 23, 2024
@frankyn frankyn added type: cleanup An internal cleanup or hygiene concern. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewsg andrewsg

Labels
api: storage Issues related to the googleapis/python-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewsg @frankyn