From 094e66d7f37e9214ad44a6115fb458adf98786b2 Mon Sep 17 00:00:00 2001 From: Daniel Azuma Date: Mon, 13 Jan 2025 12:19:30 -0800 Subject: [PATCH] chore(release): Switch to Ruby-based release reporter (#244) --- .kokoro/release.sh | 4 +--- lib/signet/oauth_1/signature_methods/hmac_sha1.rb | 4 +--- lib/signet/oauth_1/signature_methods/plaintext.rb | 4 +--- lib/signet/oauth_1/signature_methods/rsa_sha1.rb | 5 +---- lib/signet/oauth_2.rb | 4 +--- 5 files changed, 5 insertions(+), 16 deletions(-) diff --git a/.kokoro/release.sh b/.kokoro/release.sh index 34157c8..1d5ff6d 100755 --- a/.kokoro/release.sh +++ b/.kokoro/release.sh @@ -8,6 +8,4 @@ export GEM_HOME=$HOME/.gem export PATH=$GEM_HOME/bin:$PATH gem install --no-document toys -toys release install-python-tools -v -python3 -m releasetool publish-reporter-script > /tmp/publisher-script; source /tmp/publisher-script -toys release perform -v --force-republish --enable-docs --enable-rad < /dev/null +toys release perform -v --reporter-org=googleapis --force-republish --enable-docs --enable-rad < /dev/null diff --git a/lib/signet/oauth_1/signature_methods/hmac_sha1.rb b/lib/signet/oauth_1/signature_methods/hmac_sha1.rb index fa09ab7..1fa4321 100644 --- a/lib/signet/oauth_1/signature_methods/hmac_sha1.rb +++ b/lib/signet/oauth_1/signature_methods/hmac_sha1.rb @@ -4,9 +4,7 @@ module Signet # :nodoc: module OAuth1 module HMACSHA1 - def self.generate_signature \ - base_string, client_credential_secret, token_credential_secret - + def self.generate_signature base_string, client_credential_secret, token_credential_secret # Both the client secret and token secret must be escaped client_credential_secret = Signet::OAuth1.encode client_credential_secret diff --git a/lib/signet/oauth_1/signature_methods/plaintext.rb b/lib/signet/oauth_1/signature_methods/plaintext.rb index 46cb29e..b436a2b 100644 --- a/lib/signet/oauth_1/signature_methods/plaintext.rb +++ b/lib/signet/oauth_1/signature_methods/plaintext.rb @@ -3,9 +3,7 @@ module Signet # :nodoc: module OAuth1 module PLAINTEXT - def self.generate_signature \ - _base_string, client_credential_secret, token_credential_secret - + def self.generate_signature _base_string, client_credential_secret, token_credential_secret # Both the client secret and token secret must be escaped client_credential_secret = Signet::OAuth1.encode client_credential_secret diff --git a/lib/signet/oauth_1/signature_methods/rsa_sha1.rb b/lib/signet/oauth_1/signature_methods/rsa_sha1.rb index dc394ef..022d4ad 100644 --- a/lib/signet/oauth_1/signature_methods/rsa_sha1.rb +++ b/lib/signet/oauth_1/signature_methods/rsa_sha1.rb @@ -6,10 +6,7 @@ module Signet # :nodoc: module OAuth1 module RSASHA1 - def self.generate_signature \ - base_string, client_credential_secret, _token_credential_secret - - + def self.generate_signature base_string, client_credential_secret, _token_credential_secret private_key = OpenSSL::PKey::RSA.new client_credential_secret signature = private_key.sign OpenSSL::Digest.new("SHA1"), base_string # using strict_encode64 because the encode64 method adds newline characters after ever 60 chars diff --git a/lib/signet/oauth_2.rb b/lib/signet/oauth_2.rb index 7191283..956149c 100644 --- a/lib/signet/oauth_2.rb +++ b/lib/signet/oauth_2.rb @@ -114,9 +114,7 @@ def self.generate_basic_authorization_header client_id, client_password # # @return [String] # The value for the HTTP Basic Authorization header. - def self.generate_bearer_authorization_header \ - access_token, auth_params = nil - + def self.generate_bearer_authorization_header access_token, auth_params = nil # TODO: escaping? header = "Bearer #{access_token}" if auth_params && !auth_params.empty?