This repository was archived by the owner on Mar 13, 2018. It is now read-only.
Removing the condition which would return status as successful#52
Open
majidfn wants to merge 1 commit intogooglearchive:masterfrom
majidfn:core-ajax-error-fix
Open
Removing the condition which would return status as successful#52majidfn wants to merge 1 commit intogooglearchive:masterfrom majidfn:core-ajax-error-fix
majidfn wants to merge 1 commit intogooglearchive:masterfrom
majidfn:core-ajax-error-fix
Conversation
Author
|
This could be a fix for the following issue as well: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is no status on the call, the call should not be considered as successful.
For example when the back-end server is not responding although there was a
ERR_CONNECTION_RESETbut still thecore-responsewas being fire instead ofcore-error. This was as the result of status being0and and!0would returntrueforisSuccess